For .NET Core, TcpClient doesn't support the .Connect() API #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnectAsync(). This requires that our .Connect() wrapper wait for the .ConnectAsync() call to complete before calling .GetStream(), so we will make the .Connect() method awaitable.
…dbusClient for clarity.
| @@ -73,13 +74,13 @@ public ModbusClient() | |||
| /// <summary> | |||
| /// Establish connection to Master device in case of Modbus TCP. Opens COM-Port in case of Modbus RTU | |||
| /// </summary> | |||
| public void Connect() | |||
| public async Task ConnectAsync() | |||
There was a problem hiding this comment.
I would suggest to add CancellationToken support to Async Methods and also to evaluat it as well and do not trust the third party is doing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TcpClient only supports ConnectAsync() in .NET Core. This requires that our .Connect() wrapper wait for the .ConnectAsync() call to complete before calling .GetStream(), so we will make the .Connect() method awaitable.