Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adress Prefilling, upgraded version #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RadimFab
Copy link
Contributor

upgraded version - preserve original address letter case

Copy link
Member

@mrtnzlml mrtnzlml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RadimFab, happy to accept the Adress Prefilling page but I cannot accept the upgraded version of it to the University. Could you please consider removing any reference to the upgraded version? Thank you! 🙏

@@ -0,0 +1,467 @@
## Upgraded version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RadimFab, thank you for your contribution, and I apologize for my late reply.

We discussed this internally and decided that we would not like to publish or reference such a long code snippet to the University since we cannot guarantee its quality and maintenance. Instead, we believe it's better to publish it to your own GitHub repository and remove it from here.

That being said, I've asked our developers to include this functionally in the store extension, so it is available for everyone without the need for a fork (issue reference EXE-2454).

Thank you for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants