Rust: Fix Send and Sync regression in 2.6.0 (#259)

* rust: add semver check to github workflow

* rust: mark StanLibrary as Send and Sync to restore previous behavior

* c: mark version numbers as const

.github/workflows/main.yaml

@@ -300,3 +300,7 @@ jobs:
           # run all tests with feature download-bridgestan-src
           cargo test --verbose --all-features
           cargo test --verbose model_compiling -- --ignored
+      - name: Check semver for rust interface
+        uses: obi1kenobi/cargo-semver-checks-action@v2
+        with:
+          manifest-path: ./rust/Cargo.toml

rust/src/bs_safe.rs

@@ -25,6 +25,10 @@ pub struct StanLibrary {
     id: u64,
 }
 
+// Stan libraries are thread safe.
+unsafe impl Send for StanLibrary {}
+unsafe impl Sync for StanLibrary {}
+
 // To work around a bug where unloading a library
 // can lead to deadlocks.
 //

src/bridgestan.cpp

@@ -5,9 +5,9 @@
 #include "callback_stream.hpp"
 #include <sstream>
 
-int bs_major_version = BRIDGESTAN_MAJOR;
-int bs_minor_version = BRIDGESTAN_MINOR;
-int bs_patch_version = BRIDGESTAN_PATCH;
+const int bs_major_version = BRIDGESTAN_MAJOR;
+const int bs_minor_version = BRIDGESTAN_MINOR;
+const int bs_patch_version = BRIDGESTAN_PATCH;
 
 bs_model* bs_model_construct(const char* data, unsigned int seed,
                              char** error_msg) {

src/bridgestan.h

@@ -34,9 +34,9 @@ typedef void (*STREAM_CALLBACK)(const char* data, size_t size);
  * @note These were not available pre-2.0.0, so their absence
  * implies the library is in the 1.0.x series
  */
-BS_PUBLIC extern int bs_major_version;
-BS_PUBLIC extern int bs_minor_version;
-BS_PUBLIC extern int bs_patch_version;
+BS_PUBLIC extern const int bs_major_version;
+BS_PUBLIC extern const int bs_minor_version;
+BS_PUBLIC extern const int bs_patch_version;
 
 /**
  * Construct an instance of a model wrapper.