-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List unrefered inline images as attachments #5051
Comments
Comment by @alecpl on 31 Oct 2012 09:04 UTC In other words this is a request to add to attachments list inline related images that aren't used in HTML part (part can not exist, be empty, or just doesn't refer to the image by its content-id). |
Milestone changed by @alecpl on 31 Oct 2012 09:04 UTC 0.9-beta => later |
Summary changed by @alecpl on 31 Oct 2012 09:04 UTC
List unrefered inline images as attachments |
Comment by zamri on 1 Nov 2012 02:13 UTC Another example added. Pls see attachment 12.zip. This one it has 'something' in the message that it doesn't show in RC and Thunderbird. |
Comment by @alecpl on 21 Mar 2013 11:53 UTC Consider also listing images that are referred, but not displayed - text part is used for display. See #1489003. |
Comment by @alecpl on 21 Mar 2013 11:55 UTC 12.zip source is malformed. There's no headers and there's HTML content in plain/text part. |
Comment by xenon on 22 Mar 2013 09:43 UTC I'm not sure how is 'right way' for displaying inline files, but quote for RFC: 2.1 The Inline Disposition Type A bodypart should be marked `inline' if it is intended ''to be http://tools.ietf.org/html/rfc2183 Looks like even if image is not referenced from HTML part, it still should be displayed. Also, tested message from #1489003 on different software. Webmails: Gmail, Squirrelmail all of them (but not RoundCube) displays inline images. |
Comment by @alecpl on 22 Mar 2013 09:58 UTC We have a setting in Roundcube with which user can decide to display them or not below the message body. It is not so simple as RFC says. What if the message is multipart/alternative? What's inline for HTML part don't need to be inline for text. |
Comment by @alecpl on 16 Apr 2015 19:41 UTC Another sample in #1490355. |
I've encountered this issue in Roundcube v1.1.4-4.11.el7.kolab_3.4 Here's a dirty patch I wrote which "fixes" the issue by forcing all inline attachments to be displayed as normal attachments:
Note, this version has the option "Display attached images below message" which appears to be related to this, however I can find nowhere in the code where the option actually does anything. It's possible the above could be handled better further down in that file, but the above works nicely so I'm going to stop there. |
I wasnt't aware that this "issue" was going on for so long.
|
1.3.8 Still have this issue. Nor @Pesticles or @ner00 suggestions seems working in this version. |
This happens when I send a picture from an Android phone with sms to an email address. The image does not show up at all in RoundCube, either as inline nor as an attachment on the side. Just nothing at all. The above fixes do not work with Roundcube 1.3.7 and later. I found that I can fix it with the patch below in v1.3.7 (and this should work in later versions as well): In the file lib/Roundcube/rcube_message.php:
|
@uj: It still seem not to work in my case. The example message I use has the following fields:
The image is not showed inlined. |
I had updated Roundcube to v1.4.4 and forgot all about this just to have it happen today with an e-mail and the same approach I used for v1.3.6 (#5051 (comment)) still worked fine for me in v1.4.4. As a side note, opening the EML in Thunderbird displays the inline images as attachments, whereas Roundcube does not display them at all. Below is an example of the EML code which I came accross today. Message was originally sent from Gmail - unsure if web or desktop/mobile client; then received and forwarded by Outlook 2007 client/Exchange 2000 server, lastly received by hMailServer and viewed on Roundcube 1.4.4):
As mentioned, used the same approach as before in
Maybe not the correct approach but somehow it still works on the cases I've come accross. |
Thanks for the patch, I proposed a PR based on this patch: #9150 |
@alecpl What kind of solution would be accepted? Or is this a won't fix? |
* In plaintext mode: all inline images will be displayed below the message body * In HTML mode: all inline images that are **not** referenced in the message HTML body will be listed below the message body This doesn't add more CPU usage as it is using the already called HTML filtering function to discover if an inline part is referenced or not. This fixes issue roundcube#5051 and is a bit better than roundcube#9150
Reported by zamri on 31 Oct 2012 08:53 UTC as Trac ticket #1488783
See attachment. I have opened it in Thunderbird and it contains no text message but 1 gif image as an attachment. In RC, I dont see any attachment.
Keywords: attachment, design behaviour
Migrated-From: http://trac.roundcube.net/ticket/1488783
The text was updated successfully, but these errors were encountered: