Problem forwarding an email with jpg image attached received from iOS mail app

[SamsamM38]

I receive an email from iOS mail app containing a jpg image attached.
I can open the image, all works normally.
When I forward this email, the jpg image attached disappear, it not appear in body either.

All works fine if the file attached is something else like a pdf file.
Roundcube version : 1.4.5

[alecpl]

Provide a sample message, please.

[SamsamM38]

mail.txt

[alecpl]

The attachment is marked as inline. I think we have already tickets for similar issues, but I'll leave it open. I hope to have time to work on these for 1.5.

Your workaround is to use "forward as attachment" feature.

[SamsamM38]

Thank you

[SamsamM38]

The question is : why the problem appear only with an email from iOS app mail ?

[alecpl]

Most clients do not use Content-Disposition: inline on the image part for messages with a plain text body and an image attachment.

[SamsamM38]

If I used the "forward as attachment" feature, a file attachment containing the email appear + the jpg image file that did not appear with the simple "forward" command.

So to summarize : forward command, jpg file disappear, "forward as attachment" jpg file appear.
Call Mulder and Scully !

[roberthr74]

We have the same issue using Rouncube Web client. Forward as attachment works in this case.

[tomsommer]

We are also getting reports of this

[lucasmarin]

@alecpl

The problem is at compose.inc:997

            if ($part->disposition == 'inline' && $part->mimetype != 'application/pdf') {
                if (!$bodyIsHtml) {
                    continue;
                }

                $idx = $part->content_id ? ('cid:' . $part->content_id) : $part->content_location;

                if ($idx && isset($CID_MAP[$idx]) && strpos($message_body, $CID_MAP[$idx]) !== false) {
                    $replace = $CID_MAP[$idx];
                }
                else {
                    continue;
                }
            }

I saw that code above was developed by issue #7122 and removing else condition on it fix the problem on this issue.

I will investigate it, fix on my RC locally and open a PR here.

Regards.

[alecpl]

Fixed.

[Neustradamus]

Linked to:

• Fix #5051 by always showing inline attachments in list of attachments #9150
• List unrefered inline images as attachments #5051
• E-mail attachments are not visible #6279
• Attachments without optional Content-Disposition headers are not visible in message view #7117
• Problem with replies to messages with attachments from Gmail #7122
• Attachments ignored if BODYSTRUCTURE does not contain content disposition (Mercury/32 server) #7214
• Problem with forwarding/replying to the messages containing multiple inline images. #7293
• Problem forwarding an email with jpg image attached received from iOS mail app #7414
• iPhone only email attachments wont forward #7440
• Apple Mail send image files marked as inline even if it is not on body message (#7414) #7441