Merge pull request #15 from maugustoo/fix-ttl-timestamp

change ttl time from milliseconds to seconds
rpinheiroalmeida · Oct 15, 2021 · bf42d15 · bf42d15
2 parents 7779d5e + 4f62dc1
commit bf42d15
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -64,7 +64,7 @@ The object DynamodbConfig is related to Dynamodb configuration, the possible par
 | endpointUrl       | An Endpoint object representing the endpoint URL for service requests. |
 | maxRetries        |        The maximum amount of retries to attempt with a request.        |
 | httpOptions       |        A set of options to pass to the low-level HTTP request.         |
-| ttl               |               Time to Live (TTL) on the specified table.               |
+| ttl               |         Time to Live (TTL) in seconds on the specified table.          |
 
 
 ### Adding Events

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "aws-event-stream",
-  "version": "1.2.4",
+  "version": "1.2.5",
   "description": "A simple and fast EventStore for AWS.",
   "author": "Rodrigo Pinheiro de Almeida <[email protected]>",
   "license": "MIT",

diff --git a/src/provider/dynamodb.ts b/src/provider/dynamodb.ts
@@ -36,13 +36,14 @@ export class DynamodbProvider implements PersistenceProvider {
         await this.ensureTables();
         const now = new Date();
         const commitTimestamp = now.getTime();
+        const commitTimetampSeconds = Math.floor(commitTimestamp / 1000);
         const event = {
             aggregation_streamid: `${this.getKey(stream)}`,
             commitTimestamp: commitTimestamp,
             eventType: data.eventType,
             payload: data,
             stream: stream,
-            ttl: this.config.dynamodb.ttl ? (commitTimestamp + this.config.dynamodb.ttl) : undefined,
+            ttl: this.config.dynamodb.ttl ? (commitTimetampSeconds + this.config.dynamodb.ttl) : undefined,
         };
         const record = {
             Item: event,

diff --git a/test/unit/provider/dynamodb-provider.spec.ts b/test/unit/provider/dynamodb-provider.spec.ts
@@ -88,7 +88,7 @@ describe('EventStory Dynamodb Provider', () => {
                             aggregation_streamid: 'orders:1',
                             commitTimestamp: NOW.getTime(),
                             eventType: 'SENT',
-                            ttl: NOW.getTime() + 10,
+                            ttl: Math.floor(NOW.getTime() / 1000) + 10,
                             payload: {
                                 eventType: 'SENT',
                                 text: 'EVENT PAYLOAD'