added uniq parameter, update readme #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2016 14:46
|
anybody here? |
selwin
reviewed
Feb 3, 2017
|
|
||
| # If job is a repeated job, decrement counter | ||
| if repeat: | ||
| job.meta['repeat'] = int(repeat) - 1 | ||
|
|
||
| queue = self.get_queue_for_job(job) | ||
| queue.enqueue_job(job) | ||
| if not uniq or uniq and job.id not in queue.get_job_ids(): |
There was a problem hiding this comment.
This will kill performance if we have a queue with many jobs. I'm not against this feature, but it will have to be implemented in a scaleable way.
I think we can use a set to check for whether this specific function is already scheduled.
There was a problem hiding this comment.
Would it be worthwhile to just add a comment around this flag about a possible performance hit? Seems like a popular feature request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not queue scheduled job if it is already present in destination queue
By default False == save default behaivor