Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added attribute for to job if not argument present #287

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

callluis
Copy link

No description provided.

@callluis
Copy link
Author

callluis commented Mar 21, 2023

If we don't add the condition for the false then the scheduler breaks:

Traceback (most recent call last):  
File "/app/manage.py", line 10, in <module>    execute_from_command_line(sys.argv)  
File "/usr/local/lib/python3.9/site-packages/django/core/management/__init__.py", line 425, in execute_from_command_line    utility.execute()  
File "/usr/local/lib/python3.9/site-packages/django/core/management/__init__.py", line 419, in execute    self.fetch_command(subcommand).run_from_argv(self.argv)  
File "/usr/local/lib/python3.9/site-packages/django/core/management/base.py", line 373, in run_from_argv    self.execute(*args, **cmd_options)  
File "/usr/local/lib/python3.9/site-packages/django/core/management/base.py", line 417, in execute    output = self.handle(*args, **options)  
File "/usr/local/lib/python3.9/site-packages/django_rq/management/commands/rqscheduler.py", line 54, in handle    scheduler.run()  
File "/usr/local/lib/python3.9/site-packages/rq_scheduler/scheduler.py", line 479, in run    self.enqueue_jobs()  
File "/usr/local/lib/python3.9/site-packages/rq_scheduler/scheduler.py", line 450, in enqueue_jobs    self.enqueue_job(job)  
File "/usr/local/lib/python3.9/site-packages/rq_scheduler/scheduler.py", line 423, in enqueue_job    queue.enqueue_job(job, at_front=bool(job.enqueue_at_front))
AttributeError: 'Job' object has no attribute 'enqueue_at_front'

@selwin
Copy link
Contributor

selwin commented May 2, 2023

@callluis mind fixing the tests so I can merge this in?

@callluis
Copy link
Author

callluis commented May 2, 2023

Attempting to ...

@callluis
Copy link
Author

callluis commented May 2, 2023

I think I fixed the previous failing test, but now Im getting a lot of them cancelled and I don't know why. Also getting failed tests. Will try to fix those.

@selwin
Copy link
Contributor

selwin commented May 2, 2023

@callluis it may be related to the newly released RQ version. Please look at this comment rq/rq#1893 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants