Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rq-scheduler should respect the depends_on parameter like in RQ.
Job B which depends on Job A should not run if Job A has not finished.
DETAIL:
A simplified use case, there are two jobs: Job A, and Job B. Job B should not run before Job A is done.
In an environment where there are more than one rqworker running, without this code change, rq-scheduler doesn't respect job dependency. Meaning that, since there are multiple rqworkers running, Job B and Job A could run in parallel.
SIMPLE TEST:
I created like the below, and confirmed that job2 did not get picked up by the second rqworker if job1 has not finished.
job1 = s.schedule(scheduled_time=START_TIME, func=count, interval=SCRIPT_INTERVAL, repeat=1)
job2 = s.schedule(scheduled_time=START_TIME, func=say_hello, depends_on=job1)
If you like this PR, I can update the README.md afterwards. Thx!