-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap dev tools extension screen with SelectionArea #869
base: master
Are you sure you want to change the base?
Conversation
|
Please make sure to add tests :) |
What kind of tests would you expect? It's just a change in the UI. It does not look like there are currently UI Tests 🤔 |
There are tests for everything. All changes need a test |
Wow, thank you for that clear guidance 😅 So you mean widget test in that case? I have found nothing regarding how to test https://stackoverflow.com/questions/76630379/widget-test-for-selectionarea |
You could use |
Unfortunately, I'm unable to run the tests and there are currently no working golden tests in the repo. So I'm not willed to continue with that. This is a part of the output when I try to run Details
|
devtools_app_shared seems to be out of date at moment. |
By wrapping the dev tools screen with
SelectionArea
it's now possible to select text and that way copy the current values or names of providers.@rrousselGit There is no guidance on what I have to do if I want to contribute. Please let me know if there is anything more to do to ship this or just do it by yourself, that's fine for me as well.
Closes #868