Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'mochiweb' to 2.15 #22

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Update 'mochiweb' to 2.15 #22

merged 1 commit into from
Apr 21, 2017

Conversation

marvelm
Copy link
Contributor

@marvelm marvelm commented Apr 19, 2017

  • Upgrade to the latest release of mochiweb.

I need to make this change because we'd like to use html_sanitize_ex and floki in the same project, but there's a version conflict. floki requires mochiweb to be at least 2.15.0.

@ArturT
Copy link

ArturT commented Apr 20, 2017

Would be great to merge this but there is an error with one test:

  1) test should not destroy white-space /2 (HtmlSanitizeExScrubberStripTagsTest)
     test/strip_tags_test.exs:248
     Assertion with == failed
     code: "sometext with break between tags\r\nwill remove break" == strip_tags("some<b>text with break between tags</b>\r\n<i>will remove break</i>")
     lhs:  "sometext with break between tags\r\nwill remove break"
     rhs:  "sometext with break between tagswill remove break"
     stacktrace:
       test/strip_tags_test.exs:249

@marvelm
Copy link
Contributor Author

marvelm commented Apr 20, 2017

Looks like it's caused by the fact mochiweb ignores some whitespace characters. A contributor has also previously encountered this issue.

@rrrene rrrene merged commit 0dbe339 into rrrene:master Apr 21, 2017
@rrrene
Copy link
Owner

rrrene commented Apr 21, 2017

v1.2.0 contains this. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants