-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watershed Analysis Methods #1477
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging : rspatial/master to ecor/master
Aligned with "rspatial" repo updates
Merging with rspatial
Updates from rspatial fork - see Date
Update with current rspatial/terra
Merging with "rspatial"
Alignment with latest official version
Alignement
Alignment with rspatial
Alignement
alignement with "rspatial" master one
alignement
alignement
alignement
alignement
alignement
xyz list
alignement
alignement
alignement
Thank you very much for all this work. I have been a bit busy but will have a look asap. |
alignement
alignement
Thanks for accepting pull request. I just saw that the "watershed analysis" function names was changed. I will update the examples with the new names in order that all checks on examples work correctly. I will do ASAP and submit a new pull request. I also corrected my name and surname in the DESCRIPTION file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Developers,
I kindly submit my contribution to "terra" package adding some watershed analysis functions which I need and I have developed within the package in my fork ecor/terra.
Here find attached a summary of the added functions written in C/C++ and declared as methods in R:
See also discussions about the need of this kind of tools in the following issues:
#1221
#1180
I 'm available for any possible discussion.
Thank you for the job
Best
Emanuele Cordano
@ecor