Watershed Analysis - Test and Ducumentation with new names #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests and documentation for Watershed Analysis were updated with the new chosen name for the related S4 methods. |
ecor
changed the title
|
It looks like that 2nd build was not successful because of a Windows issue for terra package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and documentation were updated with the new chosen names for the related S4 methods. By @ecor forks 's side, checks were succeeded. I also inserted the possibility to calculate flow accumulation also through terrain(x,v="flowacc") calling flowAccumulation method. I let @rhijmans and others authors decide to keep it or not.
My name and ORCID as ctb , corrected in DESCRIPTION FILE
Thank you
@ecor