Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings for features to be removed/changed in RSpec 4 #2880

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pirj
Copy link
Member

@pirj pirj commented Mar 12, 2021

A few things are a bit off, e.g.:

  • no deprecation for multi-condition filtering usages 🤷
  • no specs for :if/:unless deprecation usages
  • had to flip the unless condition in snippet_extractor_spec.rb to skip it on Ruby 1.8 builds. Puzzled to understand how :unless => RSpec::Support::Ruby.jruby? && !RUBY_VERSION.start_with?('1.8.') was working (example failure)
  • should we add deprecation warnings when running on rbx/ree/Ruby < 2.3?

This is purposed to be released as version 3.99.
Sibling PRs:

Release strategy: #2880 (comment)
RSpec 4 plan: https://github.com/rspec/rspec/issues/61
Changes: https://github.com/rspec/rspec-core/blob/4-0-dev/Changelog.md#development

TODO

  • merge this PR, then rspec-expectations PR, then rspec-mocks PR
  • revert this spec/spec_helper.rb change

@pirj pirj self-assigned this Mar 12, 2021
@pirj pirj requested review from JonRowe and benoittgt March 12, 2021 09:18
@pirj
Copy link
Member Author

pirj commented Mar 12, 2021

@JonRowe Am I doing the right thing?

@pirj pirj mentioned this pull request Mar 12, 2021
53 tasks
@pirj pirj added this to the 4.0 milestone Mar 12, 2021
@JonRowe
Copy link
Member

JonRowe commented Mar 12, 2021

@pirj yep, thats the exactly the kind of thing we'll want in a final 3.x release.

We'll follow the 2.x strategy of:

  • Release a 3.10 patch of any final bug fixes
  • Release a final minor version containing any final enchancements
  • Release 3.99 containing these deprecations
  • Release 4.x

It's sufficient to keep these as a PR until we get to releasing 3.99, the first two steps are just release management as usual

@pirj pirj force-pushed the add-major-update-deprecation-warnings branch 3 times, most recently from 6abb3f2 to eee9511 Compare March 14, 2021 20:19
@pirj pirj marked this pull request as ready for review March 14, 2021 22:51
@pirj pirj force-pushed the add-major-update-deprecation-warnings branch 2 times, most recently from 6420630 to 40b566b Compare March 15, 2021 07:06
@pirj
Copy link
Member Author

pirj commented Mar 15, 2021

Green!

I have seen features/command_line/init.feature:25, and features/command_line/bisect.feature (on JRuby) failing intermittently on CI. Might be flaky. Couldn't reproduce locally.

@benoittgt
Copy link
Member

Thanks @pirj for this PR. 🙌🏻

should we add deprecation warnings when running on rbx/ree/Ruby < 2.3?

It means people will always have the deprecations when they use the last version chosen by bundler for their Ruby version?

@benoittgt
Copy link
Member

benoittgt commented May 5, 2021

@pirj are we good to merge it?

Sorry I scrolled back and saw

It's sufficient to keep these as a PR until we get to releasing 3.99, the first two steps are just release management as usual

@pirj pirj modified the milestones: 4.0, 3.99 Jun 3, 2022
Comment on lines +84 to +85
# Temporary measure to prevent failures when run in a sub-build from other repos
# c.raise_errors_for_deprecations!
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reverted when all three are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants