Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call super in Formatter.close methods to ensure sync is reset #3094

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Call super in Formatter.close methods to ensure sync is reset #3094

wants to merge 9 commits into from

Commits on Jun 28, 2024

  1. Call super in Formatter.close methods to ensure sync is reset

    @rahearn
    rahearn committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    38abe6e View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Try to move guard up into close method

    @rahearn
    rahearn committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    a4d72da View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Add test verifying that output.sync is reset when close is called 

    This test fails without adding the call to super in BaseTextFormatter#close
    @rahearn
    rahearn committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    8f660e4 View commit details
    Browse the repository at this point in the history

  2. Add explicit guard for whether sync was started on an output that sup… 

    …ports it
    @rahearn
    rahearn committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    d7697b3 View commit details
    Browse the repository at this point in the history

  3. Clean up forgotten commented-out code

    @rahearn
    rahearn committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    76aa327 View commit details
    Browse the repository at this point in the history

  4. Create struct with hash argument instead of keyword

    @rahearn
    rahearn committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    8867e9d View commit details
    Browse the repository at this point in the history

  5. Oh yeah - old-style hash syntax

    @rahearn
    rahearn committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b0aceb4 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Address PR feedback

    @rahearn
    rahearn committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    8d31de9 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Move reset sync test to a shared example group

    @rahearn
    rahearn committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d62ec7a View commit details
    Browse the repository at this point in the history