Work around ammeter' incompatibility with RSpec 4 #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
workaround-ammeter-multi-condition-filtering
branch
2 times, most recently
from
3f01b64
to
a3bebfd
Compare
JonRowe
reviewed
Feb 22, 2021
See: - rspec/rspec-core#1821 - rspec/rspec-core#2874 - alexrothenberg/ammeter#64 - example failure (Ammeter::RSpec::Rails::GeneratorExampleGroup that defines destination is not included) https://github.com/rspec/rspec-core/pull/2874/checks?check_run_id=1942170588 Alternative to #2468
pirj
force-pushed
the
workaround-ammeter-multi-condition-filtering
branch
from
452dfb7
to
0d92b82
Compare
JonRowe
approved these changes
Feb 22, 2021
This was referenced Mar 7, 2021
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
Less impactful alternative to #2468