Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RSpec::Support.thread_local_data thread but not fiber local #581

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Jun 26, 2023

Fixes #580

JonRowe added a commit that referenced this pull request Jun 26, 2023
JonRowe added a commit to rspec/rspec-core that referenced this pull request Jun 26, 2023
rspec/rspec-support#581 makes this fail, but its an old "safety" check
and not really needed...
JonRowe added a commit to rspec/rspec-core that referenced this pull request Jun 26, 2023
rspec/rspec-support#581 makes this fail, but its an old "safety" check
and not really needed...
JonRowe added a commit that referenced this pull request Jun 26, 2023
@JonRowe JonRowe force-pushed the fix-thread-local branch 2 times, most recently from 6f430c7 to afb75a5 Compare June 26, 2023 14:54
@JonRowe JonRowe merged commit 65addb0 into main Jun 26, 2023
@JonRowe JonRowe deleted the fix-thread-local branch June 26, 2023 15:18
JonRowe added a commit that referenced this pull request Jun 26, 2023
Make RSpec::Support.thread_local_data thread but not fiber local
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This is not thread local, it is in fact fiber local.
1 participant