Improve access to option values + use htmltools to create some css code #1868
Conversation
| @@ -309,14 +292,23 @@ get_table_defs <- function(data) { | |||
| if (table_width == "auto") { | |||
|
|
|||
| if (all(grepl("px", widths, fixed = TRUE))) { | |||
| # FIXME sometimes ends up being 0? #1532 and quarto-dev/quarto-cli#8233 | |||
| table_width <- "0px" | |||
| } else if (all(grepl("%", widths, fixed = TRUE))) { | |||
| table_width <- "100%" | |||
| } | |||
| } | |||
|
|
|||
| if (table_width != "auto") { | |||
There was a problem hiding this comment.
@rich-iannone to fix #1532, should we just have this condition be
| if (table_width != "auto") { | |
| if (!table_width %in% c("auto", "0", "0px")) { |
If so, I will create a PR after this one is merged and update all snapshots.
I did the refactoring here to make the potential fix clearer in the future
There was a problem hiding this comment.
I like the version that catches the zero-width table! I’d welcome a future PR that addresses that problem.
| filtered_tbl <- dplyr::filter(fn_tbl, locname == !!locname) | ||
| dplyr::summarize(filtered_tbl, fs_id_c = paste(fs_id, collapse = delimiter)) | ||
| fs_ids <- vctrs::vec_slice(fn_tbl$fs_id, fn_tbl$locname == locname) | ||
| paste(fs_ids, collapse = delimiter) |
There was a problem hiding this comment.
Note that I refactored coalesce_marks() to return a single string because the resulting data frame (1 col x 1 row) previously was never used, and all code needed to access the fs_id_c variable. e86b842
There was a problem hiding this comment.
This is a great improvement! Yeah, a vector is all we need.
Refactor code to get multiple option values.
| #' @export | ||
| `$.gt_option` <- function(x, name) { | ||
| out <- .subset2(x, name) | ||
| if (is.null(out)) { | ||
| cli::cli_abort("Can't find option {.val {name}}.") | ||
| } | ||
| out | ||
| } |
There was a problem hiding this comment.
This is to avoid a typo when developing dt_options_get_values(data)$olumn_label errors instead of returning NULL, similar to the method that tibble defines for tables. I have been bitten while developing, so I thought it was better to catch the error on the spot for easier debugging
exibble$num2
#> Warning: Unknown or uninitalized column
mtcars$nonexistent
#> NULL
olivroy
changed the title
Summary
fmt_time(),fmt_datetime()andfmt_date()in own filetab_options()values to facilitate reusing them.Related GitHub Issues and PRs
Before
This PR
Checklist
testthatunit tests totests/testthatfor any new functionality.