-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new urls
to metadata
#795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
R/pin-meta.R
Outdated
@@ -133,6 +135,9 @@ test_api_meta <- function(board) { | |||
testthat::expect_snapshot_error( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this test could be run just once for pin_write()
since the code doesn't vary across backends?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, great point, yep 👍
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
One thing we thought about when listening to JD Long's keynote talk at posit::conf last month was the value of making sure it is as easy as possible connect datasets to documentation. This PR is inspired by those thoughts and adds a new option for storing
urls
(a character vector) along with your dataset.It's used like this:
Created on 2023-10-18 with reprex v2.0.2
I added the URLs to the Connect preview, which you can see here:
https://colorado.posit.co/rsc/httpbey-pin/
Any thoughts on a better way to present that?