Update getCurrentOutputInfo() on element resize or visibility change #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing's container size changes (instead of only when the window resizes)
…ntersectionObserver to send size/hidden state
cpsievert
changed the title
…display:none on output children when resizing
cpsievert
force-pushed
the
resize-observer
branch
from
e8f7f80 to
f9c0d46
Compare
This comment was marked as outdated.
This comment was marked as outdated.
@cpsievert what does a "stretchy output container" look like? e.g. what's an example app that doesn't resize the image properly without that fbe9d24 code? (Want to make sure my PR #3683 isn't overlooking an edge case, and that it's compatible with this fix.) |
cpsievert
commented
Sep 15, 2022
| function doSendOutputHiddenState() { | ||
| const visibleOutputs = {}; | ||
| io.observe(el); | ||
| $(el).data("shiny-intersection-observer", io); |
There was a problem hiding this comment.
Double-check on the UX with scrolling here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently shiny.js only sends input values tied to output values (e.g.,
.clientdata_output_{id}_width, etc) to the server (i.e.,getCurrentOutputInfo()) when the window resizes (or if certain Bootstrap events happens). This PR leveragesResizeObserver()andIntersectionObserver()to update those relevant input values whenever the element is resized or has its visibility changed (regardless of what has caused that change)TODO
Investigate more why fbe9d24 is needed(it's needed because, if the output container is stretchy, the image won't know to shrink when the container shrinks since it's size is determined by the parent)