Phantom Types TODO List #392
Comments
|
I'll take What do you think would be the best diff to look at so I don't submit something unexpected in a PR? |
|
@BrianHicks For I think for |
|
Mmm, my bad. I guess I was after general advice for the other 356 items to make this low-hanging fruit even lower. Based on our chat elsewhere, here's how you'd upgrade one item:
|
|
also, ah dang you already did this in the wiki! Nice! I just missed it. |
|
I did textTransform and its values since I identified that one as a very easy one and I am a total beginner on this stuff. I did:
If you can review when you get a chance and let me know if I did it correctly I can submit you a list of some others I can do (with less hand-holding/reviewing). Here it is: textTransform Hopefully I am more help than trouble! |
|
looks like I'll also need to do the linearGradients for backgroundImage |
|
I'll start with the overflow props (220-223)! |
|
👋 |
|
I can work on:
|
|
Nice, sounds good @sturgman! I avoid including things that are deprecated, or which are too new to have widespread browser support yet. I don't think we need the aliases. |
|
I can take the
Edit: #404 |
|
#408 includes:
|
|
I'd like to take some Border with single argument:
Border with multiple arguments:
New border style values:
|
|
Sounds great @owanturist! 🤘 |
|
I'd like to grab all @rtfeldman please mark |
|
I'd would like to add the following properties 🙂
|
|
I see that the following SVG related properties are missing from the TODO list:
I'll take these if they should be added :) |
|
@rtfeldman I'm going to adapt |
|
@brianvanburken Added |
|
@rtfeldman I think |
|
@rtfeldman I'd like to grab next properties:
with corresponding values:
and I think those properties are invalid (I haven't found any of them):
|
|
I'll be working on the column related properties next:
|
|
I'll pick up the |
|
Actually, the following list of properties are tagged as experimental on the MDN website, so maybe we should remove them from the list:
|
|
I'll pick up the |
|
@rtfeldman I want to implement I see they can also accept a few experimental values: So should I add support for these values or should they be removed from the list? |
|
I'll also take |
|
At least the following properties are also experimental and should probably be removed from the list: |
|
I've edited the list to be up-to-date with the latest merges.
|
|
I'll be adding |
|
Holidays are coming, let's add a few phantom types on the beach ! I will give it a try with the flexbox ones:
Edit: pull request done |
|
hey, it's hacktoberfest! This would be a really good issue for people who are working on that. If you add a as for myself, I plan to make several PRs on this to get my yearly t-shirt 😉 |
|
That would be fantastic! I've been focusing on getting the |
|
getting back into it with:
|
|
I've taken the properties in the list below (PR #505)
|
|
I am working on re-implementing the tests and adding some functions. You can check it out here. I have merged several other contributions into this branch though... I hope that is not a huge problem. I used the type aliases suggested by @rlefevre in #453, but without the |
|
@leifhelm That's great! I have posted the work-around to make |
|
Last year I created a list of all CSS properties by crawling Mozilla's developer network site. Then I painstakingly crossed off all that properties and values the Phantom Types branch had. In this gist you can see what still needs to be done to fully cover the whole CSS spec: https://gist.github.com/brianvanburken/756377e61899e5a5a92add5069d0af4f While looking crossing off I found some differences between the spec and implementation that I tried to correct in #517. These question also arose that need to be looked into:
|
|
I added all Logical margins and padding properties in a PR I just made (#550) because it seems like nobody assigned themselves that and they are no longer experimental, hope I didn't clash with anybody ^^'
Based on the new list @brianvanburken made, I'll try to give myself all the Logical border ( |
|
I'll work on these next and add a PR link in this post when I'm done ^^: Logical scroll margins and padding
Logical border radii
|
|
I've been combing through the todo list some more (and made my own fork so I could keep track of changes that have happened since the last list, as well as the PRs I've made) and I found that |
|
I noticed that when it comes to the documentation of CSS values in the Css module, some docs link to to the values section of the property that uses this value on MDN and use the property's CSS name: ...while others reference the Elm documentation and the Elm function name for that property. As far as I know there isn't a consistency rule for what it should be? (All the stuff I've written so far use URLs to the Elm functions and use the Elm function naming for properties) |
This issue will help coordinate efforts on #375 (the
phantom-typesbranch)If you'd like to pitch in, awesome! Here are some guidelines on how to contribute: https://github.com/rtfeldman/elm-css/wiki/Phantom-Types:-Contributing
If you'd like to grab one (or a related set) of these, comment below and I'll add your name! This way we can avoid stepping on each others' toes.
Grabbed
width@edkvheight@edkvminWidth@edkvminHeight@edkvmaxWidth@edkvmaxHeight@edkvtextShadow@brianvanburkentextShadow2@brianvanburkentextShadow3@brianvanburkentextShadow4@brianvanburkenIf you'd like to grab something, please leave a comment below!
Available to convert
blinkbottomboxShadow2boxShadow3boxShadow4boxShadow5boxShadow6breakWordcheckedcircleclipcolumncolumnReversecontentcurrentColorcursorAliasdecimaldecimalLeadingZerodegdirdisableddisceachLineellipsisemptyenabledfeatureOfffeatureOnfeatureTagfeatureTag2fillAvailablefirstfirstChildfirstLetterfirstLinefirstOfTypefitContentflatflexflex2flex3flexBasisflexDirectionflexFlow1flexFlow2flexGrowflexShrinkflexWrapfocusfullscreengradhanginghorizontalhoverimportantindeterminateinlineListIteminlineTableinsideinvalidjustifyAlljustifyContentlanglastChildlastOfTypeletterSpacinglineHeightlineThroughlinearGradientlinearGradient2linklistItemlistStylePositionlistStyleTypelowerAlphalowerGreeklowerLatinlowerRomanmanipulationmaxContentminContentnthChildnthLastChildnthLastOfTypenthOfTypeonlyChildonlyOfTypeoptionaloutOfRangeoutlineoutline3outlineColoroutlineOffsetoutlineStyleoutlineWidthoutsideoverlinepanDownpanLeftpanRightpanUppanXpanYpinchZoompreserve3dpropertyqtradreadWriterequiredresizerootrowrowReversescopescreenBlendModeselectionspaceAroundspaceBetweenstrokesrc_targettextAlignLasttextEmphasisColortextIndenttextIndent2textIndent3textOverflowthickthintoptouchActiontransformBoxtransformStyletransparenttrueturnupperAlphaupperLatinupperRomanvalidverticalviewBoxvisitedwrapwrapReverseDone!
absoluteactiveafteraliasalignItemsalignSelfallallPetiteCapsallScrollallSmallCapsarabicIndicarmenianautobackgroundAttachmentbackgroundAttachmentsbackgroundBlendModebackgroundBlendModesbackgroundClipbackgroundClipsbackgroundColorbackgroundOriginbackgroundOriginsbaselinebatchbeforebengaliblockboldbolderborderBoxboxShadowcellcenterchcjkEarthlyBranchcjkHeavenlyStemcmcolResizecolorcolorBurncolorDodgecolor_commonLigaturescontentBoxcontextMenucontextualcopycrosshaircursivecursordarkendasheddefaultdefaultBoxShadowdevanagaridiagonalFractionsdifferencediscretionaryLigaturesdisplaydisplayFlexdotteddoubleeResizeemendewResizeexexclusionfantasyfirstBaselinefixedflexEndflexStartfontFamiliesfontFamilyfontSizefontStylefontVariantCapsfontVariantLigaturesfontVariantNumericfontWeightgeorgiangrabgrabbinggridgroovegujaratigurmukhihardLighthelphexhistoricalLigatureshslhslahueinchesinheritinitialinlineinlineBlockinlineFlexinsetintitalickannadakhmerlaolargelargerlastBaselineleftlightenlighterliningNumslistStylelistStyle2listStyle3localluminositymalayalammediummmmonospacemovemultiplymyanmarnResizeneResizeneswResizenoCommonLigaturesnoContextualnoDiscretionaryLigaturesnoDropnoHistoricalLigaturesnonenormalnotAllowednsResizenumnwResizenwseResizeobliqueoldstyleNumsordinaloriyaoutsetoverlaypaddingBoxpcpctpetiteCapspointerprogressproportionalNumspseudoClasspseudoElementptpxremrevertrgbrgbaridgerightrowResizesResizesafeCentersansSerifsaturationscreenscrollseResizeselfEndselfStartserifslashedZerosmallsmallCapssmallersoftLightsolidstackedFractionsstartstretchswResizesystemUitabletableCaptiontableCelltableColumntableColumnGrouptableFooterGrouptableHeaderGrouptableRowtableRowGrouptabularNumstelugutexttext_thaititlingCapsunicaseunsafeCenterunseturlverticalTextvhvmaxvminvwwResizewaitwavyxLargexSmallxxLargexxSmallzerozoomInzoomOutbackgroundImagebackgroundPositionbackgroundPosition2backgroundPosition4backgroundSizebackgroundSize2bottom_deggradleft_linearGradientradright_stopstop2totoCornertop_turnoverflowoverflowWrapoverflowXoverflowYtextTransformcapitalizeuppercaselowercasefullWidthtextRenderingoptimizeLegibilityoptimizeSpeedgeometricPrecisiontextOrientationmixeduprightsidewayscaptionSideborderCollapseborderSpacingborderSpacing2separatecollapseemptyCellsshowhidetableLayoutverticalAlignsubsupertextToptextBottommiddledirectionltrrtltextAlignmatchParentjustifytoBottomtoBottomLefttoBottomRighttoLefttoRighttoToptoTopLefttoTopRightpositionrelativestaticstickytopbottomleftrightzIndexbackgroundRepeatbackgroundRepeat2noRepeatrepeatrepeatXrepeatYroundspaceborderborder2border3borderColorborderColor2borderColor3borderColor4borderStyleborderWidthborderWidth2borderWidth3borderWidth4borderBottomborderBottom2borderBottom3borderBottomColorborderBottomStyleborderBottomWidthborderTopborderTop2borderTop3borderTopColorborderTopStyleborderTopWidthborderRightborderRight2borderRight3borderRightColorborderRightStyleborderRightWidthborderLeftborderLeft2borderLeft3borderLeftColorborderLeftStyleborderLeftWidththickthinnowrapprepreLinepreWrapwhiteSpacefloatwordBreakbreakAllkeepAllvisibilityvisiblecontaincoverborderRadiusborderRadius2borderRadius3borderRadius4borderTopLeftRadiusborderTopLeftRadius2borderTopRightRadiusborderTopRightRadius2borderBottomLeftRadiusborderBottomLeftRadius2borderBottomRightRadiusborderBottomRightRadius2fillpaddingpadding2padding3padding4paddingBottompaddingLeftpaddingRightpaddingTopmarginmargin2margin3margin4marginBottommarginLeftmarginRightmarginToptextDecorationtextDecoration2textDecoration3textDecorationColortextDecorationLinetextDecorationLine3textDecorationStyleunderlineoverlinelineThroughborderImageOutsetborderImageOutset2borderImageOutset3borderImageOutset4borderImageWidthborderImageWidth2borderImageWidth3borderImageWidth4all_balancebalanceAllcolumnCountcolumnFillcolumnGapcolumnRulecolumnRule2columnRule3columnRuleColorcolumnRuleStylecolumnRuleWidthcolumnSpancolumnWidthcolumnscolumns2boxSizingarcsbevelboundingBoxbuttclonecompresscropdashesfillBoxgapsmiterslicesquarestrokeAlignstrokeAlignstrokeBoxstrokeBreakstrokeColorstrokeDashCornerstrokeDashJustifystrokeDasharraystrokeDashoffsetstrokeImagestrokeLinecapstrokeLinejoinstrokeLinejoin2strokeMiterlimitstrokeOpacitystrokeOriginstrokePositionstrokePosition2strokePosition4strokeRepeatstrokeRepeat2strokeSizestrokeSize2strokeWidthstupidcalcplusminusbothclearzoomopacityinlineEndinlineStartmatrixmatrix3dperspectiverotaterotate3drotateXrotateYrotateZscalescale2scale3dscaleXscaleYscaleZskewskew2skewXskewYtranslatetranslate2translate3dtranslateXtranslateYtranslateZtransformThe text was updated successfully, but these errors were encountered: