Phantom types: background-repeat #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolgap
reviewed
Apr 23, 2018
src/Css.elm
Outdated
| , unset : Supported | ||
| } | ||
| -> Style | ||
| backgroundRepeat2 (Value repeat) = |
There was a problem hiding this comment.
I think you might've missed an argument here? 😄
There was a problem hiding this comment.
haaaaaaaaaaaaa yeah
rtfeldman
requested changes
Apr 24, 2018
src/Css.elm
Outdated
|
|
||
|
|
||
| {-| [Repeat a background](#backgroundRepeat) side to side. | ||
| -} |
There was a problem hiding this comment.
On these Value docs, can we get links to https://developer.mozilla.org/en-US/docs/Web/CSS/background-repeat#Values and mention that this compiles to the "repeat-x" value in CSS? (Similar to this, for example.)
Code examples would also be great, even if they're copy/pasted from the background docs. 😄
| backgroundRepeat2 space round | ||
|
|
||
| If you only need to set one value for both, see | ||
| [`backgroundRepeat`](#backgroundRepeat) instead. |
There was a problem hiding this comment.
Love the explanation and linking between backgroundRepeat and backgroundRepeat2! 😍
|
did! |
|
Wonderful! Thank you @BrianHicks! 😻 |
rtfeldman
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
background-repeatProgress on my bits of #392