Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directive doesn't need to be terminal anymore #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gabegorelick
Copy link
Collaborator

See #132

@rubenv
Copy link
Owner

rubenv commented Dec 8, 2014

One thing I'm wondering about: does terminal: true prevent the body from being parsed?

And if we turn it off: will it be parsed / compiled?

In the directive, we do $animate.leave(oldContents); immediately, so if we can avoid Angular.JS from processing the contents of the directive, all the better.

But maybe this is covered by priority? I'm not intimate with the deep internals of the Angular.JS compile loop to properly know the true impact of this.

@gabegorelick
Copy link
Collaborator Author

This is why I didn't directly commit this patch ;)

I believe priority and terminal only relate to what happens when there are multiple directives on the same element. But I'm not an expert either.

@gabegorelick
Copy link
Collaborator Author

This is the best explanation I've seen: http://stackoverflow.com/a/15266968

@princed
Copy link

princed commented Jul 17, 2015

@rubenv @gabegorelick Is it going to to be merged? We've bumped into this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants