Fix RSpec/DescribeClass

ruby-grape · Oct 6, 2024 · bd928cb · bd928cb
1 parent e02799c
commit bd928cb
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 24 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -22,17 +22,6 @@ Naming/VariableNumber:
     - 'spec/grape/exceptions/validation_errors_spec.rb'
     - 'spec/grape/validations_spec.rb'
 
-# Offense count: 1
-# Configuration parameters: IgnoredMetadata.
-RSpec/DescribeClass:
-  Exclude:
-    - '**/spec/features/**/*'
-    - '**/spec/requests/**/*'
-    - '**/spec/routing/**/*'
-    - '**/spec/system/**/*'
-    - '**/spec/views/**/*'
-    - 'spec/grape/named_api_spec.rb'
-
 # Offense count: 2
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: SkipBlocks, EnforcedStyle, OnlyStaticConstants.

diff --git a/spec/grape/named_api_spec.rb b/spec/grape/named_api_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe 'A named API' do
+describe Grape::API do
   subject(:api_name) { NamedAPI.endpoints.last.options[:for].to_s }
 
   let(:api) do
@@ -11,9 +11,11 @@
     end
   end
 
-  before { stub_const('NamedAPI', api) }
+  let(:name) { 'NamedAPI'}
+
+  before { stub_const(name, api) }
 
   it 'can access the name of the API' do
-    expect(api_name).to eq 'NamedAPI'
+    expect(api_name).to eq name
   end
 end
diff --git a/spec/grape/util/inheritable_setting_spec.rb b/spec/grape/util/inheritable_setting_spec.rb
@@ -221,16 +221,16 @@
       subject.namespace_reverse_stackable[:namespace_reverse_stackable_thing] = [:namespace_reverse_stackable_foo_bar]
       subject.route[:route_thing] = :route_foo_bar
       expect(subject.to_hash).to match(
-                                   global: { global_thing: :global_foo_bar },
-                                   namespace: { namespace_thing: :namespace_foo_bar },
-                                   namespace_inheritable: {
-                                     namespace_inheritable_thing: :namespace_inheritable_foo_bar
-                                   },
-                                   namespace_stackable: { namespace_stackable_thing: [:namespace_stackable_foo_bar, [:namespace_stackable_foo_bar]] },
-                                   namespace_reverse_stackable:
-                                     { namespace_reverse_stackable_thing: [[:namespace_reverse_stackable_foo_bar], :namespace_reverse_stackable_foo_bar] },
-                                   route: { route_thing: :route_foo_bar }
-                                 )
+        global: { global_thing: :global_foo_bar },
+        namespace: { namespace_thing: :namespace_foo_bar },
+        namespace_inheritable: {
+          namespace_inheritable_thing: :namespace_inheritable_foo_bar
+        },
+        namespace_stackable: { namespace_stackable_thing: [:namespace_stackable_foo_bar, [:namespace_stackable_foo_bar]] },
+        namespace_reverse_stackable:
+          { namespace_reverse_stackable_thing: [[:namespace_reverse_stackable_foo_bar], :namespace_reverse_stackable_foo_bar] },
+        route: { route_thing: :route_foo_bar }
+      )
     end
   end
 end