Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RUBYOPT's handling in tests #1097

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Apr 18, 2024

  1. Improve RUBYOPT's handling in tests

    When debugging the issue related to ruby/irb#919,
    I noticed that debugger tests don't respect the IRB version I specified
    in the Gemfile. This is because console tests force override the RUBYOPT
    env, which will remove the `-rbundler/setup` injected by bundler.
    
    Further more, if tests use `run_rdbg` with the `rubyopt` option, the
    RUBYOPT will be overridden yet again.
    
    So in this commit I did 2 improvements:
    
    1. `run_rdbg` should append instead of override RUBYOPT
    2. If tests are executed with bundler, we also run the debugger in PTY
       process with bundler by appending `-rbundler/setup` to RUBYOPT
    st0012 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ec352d2 View commit details
    Browse the repository at this point in the history