Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
Encoding::Converter
.More specifically, it:
Encoding::Converter::encoding
: Removed (lives inbuiltin.rbs
)Encoding::Converter
{search_convpath,initialize}
: Addedflags
variant, split apartnewlines
vs explicit newline arguments==
: RHS is nowuntyped
{convert,insert_output,putback}
now accepts implicit argsconvpath
no longer returnsconversion_path
(It's not[encoding,encoding]
but[Encoding,Encoding]
)last_error
: Merged return typesprimitive_convert
: Now takes implicitint
andstring
s, also added flags variantreplacement=
now takesboolish
TODO: finalize tests