swesterman/23 11 07/kernel #1640
Draft
+1,363
−854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sampersand
commented
Nov 23, 2023
sampersand
commented
- updating kernel
- more updates
- more updates
- q
|
(this requires a few of my other commits to be merged before I finalize this) |
ParadoxV5
reviewed
Nov 23, 2023
ParadoxV5
reviewed
Nov 23, 2023
Comment on lines
-1304
to
-1307
| def self?.rand: () -> Float | ||
| | (Integer arg0) -> Integer | ||
| | (::Range[Integer] arg0) -> Integer | ||
| | (::Range[Float] arg0) -> Float |
There was a problem hiding this comment.
Have you finished self?.rand? My IRB accepts both 0.0 and 0..0.
There was a problem hiding this comment.
No I havent, it's one of the remaining functions left. It's really weird.
ParadoxV5
reviewed
Nov 23, 2023
Comment on lines
+1583
to
+1589
| interface _Timeout | ||
| def divmod: (1) -> [int, _TimeoutNSecs] | ||
| end | ||
|
|
||
| interface _TimeoutNSecs | ||
| def *: (1000000000) -> int | ||
| end |
There was a problem hiding this comment.
Implementation details talk aside – what classes beside Integer sastisfies the _Timeout interface, interstingly?
4.5.divmod(1)[1] * 1000000000 #=> 500000000.0
ParadoxV5
reviewed
Nov 23, 2023
Comment on lines
+1701
to
+1709
| def self?.test: ( | ||
| 'b' | 'c' | 'd' | 'e' | 'f' | 'g' | 'G' | 'k' | 'o' | 'O' | 'p' | 'S' | 'u' | 'z' | | ||
| 98 | 99 | 100 | 101 | 102 | 103 | 71 | 107 | 111 | 79 | 112 | 83 | 117 | 122, | ||
| IO | path file) -> bool | ||
| | ('l' | 'r' | 'R' | 'w' | 'W' | 'x' | 'X' | 108 | 114 | 82 | 119 | 87 | 120 | 88, path filename) -> bool | ||
| | ('s' | 115, IO | path filename) -> Integer? | ||
| | ('M' | 'A' | 'C' | 77 | 65 | 67, IO | path file) -> Time | ||
| | ('-' | '=' | '<' | '>' | 45 | 60 | 61 | 62, IO | path file1, IO | path file2) -> bool | ||
| | (String | int cmd, IO | path file1, ?IO | path file2) -> (bool | Integer? | Time) |
There was a problem hiding this comment.
The only valid options are specified in the docs i guess … ? 🤷
ParadoxV5
reviewed
Nov 23, 2023
Comment on lines
-1717
to
-1792
| # <!-- | ||
| # rdoc-file=process.c | ||
| # - exec([env,] command... [,options]) | ||
| # --> | ||
| # Replaces the current process by running the given external *command*, which | ||
| # can take one of the following forms: | ||
| # | ||
| # `exec(commandline)` | ||
| # : command line string which is passed to the standard shell | ||
| # `exec(cmdname, arg1, ...)` | ||
| # : command name and one or more arguments (no shell) | ||
| # `exec([cmdname, argv0], arg1, ...)` | ||
| # : command name, `argv[0]` and zero or more arguments (no shell) | ||
| # | ||
| # | ||
| # In the first form, the string is taken as a command line that is subject to | ||
| # shell expansion before being executed. | ||
| # | ||
| # The standard shell always means `"/bin/sh"` on Unix-like systems, otherwise, | ||
| # `ENV["RUBYSHELL"]` or `ENV["COMSPEC"]` on Windows and similar. The command is | ||
| # passed as an argument to the `"-c"` switch to the shell, except in the case of | ||
| # `COMSPEC`. | ||
| # | ||
| # If the string from the first form (`exec("command")`) follows these simple | ||
| # rules: | ||
| # | ||
| # * no meta characters, | ||
| # * not starting with shell reserved word or special built-in, | ||
| # | ||
| # | ||
| # Ruby invokes the command directly without shell. | ||
| # | ||
| # You can force shell invocation by adding ";" to the string (because ";" is a | ||
| # meta character). | ||
| # | ||
| # Note that this behavior is observable by pid obtained (return value of spawn() | ||
| # and IO#pid for IO.popen) is the pid of the invoked command, not shell. | ||
| # | ||
| # In the second form (`exec("command1", "arg1", ...)`), the first is taken as a | ||
| # command name and the rest are passed as parameters to command with no shell | ||
| # expansion. | ||
| # | ||
| # In the third form (`exec(["command", "argv0"], "arg1", ...)`), starting a | ||
| # two-element array at the beginning of the command, the first element is the | ||
| # command to be executed, and the second argument is used as the `argv[0]` | ||
| # value, which may show up in process listings. | ||
| # | ||
| # In order to execute the command, one of the `exec(2)` system calls are used, | ||
| # so the running command may inherit some of the environment of the original | ||
| # program (including open file descriptors). | ||
| # | ||
| # This behavior is modified by the given `env` and `options` parameters. See | ||
| # ::spawn for details. | ||
| # | ||
| # If the command fails to execute (typically Errno::ENOENT when it was not | ||
| # found) a SystemCallError exception is raised. | ||
| # | ||
| # This method modifies process attributes according to given `options` before | ||
| # `exec(2)` system call. See ::spawn for more details about the given `options`. | ||
| # | ||
| # The modified attributes may be retained when `exec(2)` system call fails. | ||
| # | ||
| # For example, hard resource limits are not restorable. | ||
| # | ||
| # Consider to create a child process using ::spawn or Kernel#system if this is | ||
| # not acceptable. | ||
| # | ||
| # exec "echo *" # echoes list of files in current directory | ||
| # # never get here | ||
| # | ||
| # exec "echo", "*" # echoes an asterisk | ||
| # # never get here | ||
| # | ||
| def self?.exec: (String command, *String args, ?unsetenv_others: boolish, ?pgroup: true | Integer, ?umask: Integer, ?in: redirect_fd, ?out: redirect_fd, ?err: redirect_fd, ?close_others: boolish, ?chdir: String) -> bot | ||
| | (Hash[string, string?] env, String command, *String args, ?unsetenv_others: boolish, ?pgroup: true | Integer, ?umask: Integer, ?in: redirect_fd, ?out: redirect_fd, ?err: redirect_fd, ?close_others: boolish, ?chdir: String) -> bot | ||
|
|
ParadoxV5
reviewed
Nov 23, 2023
| @@ -2103,7 +2079,7 @@ module Kernel : BasicObject | |||
| # Returns true if two objects do not match (using the *=~* method), otherwise | |||
| # false. | |||
| # | |||
| def !~: (untyped) -> bool | |||
| def !~: [T] (T other) -> bool | |||
There was a problem hiding this comment.
The [T] here has no practical effect.
ParadoxV5
reviewed
Nov 23, 2023
Comment on lines
+2298
to
+2300
| # if no method is given, defaults to `each` | ||
| # size is enum's yield | ||
| # ^ todo |
ParadoxV5
reviewed
Nov 23, 2023
ParadoxV5
reviewed
Nov 23, 2023
| @@ -2759,7 +2750,7 @@ module Kernel : BasicObject | |||
| # | |||
| # 1.public_send(:puts, "hello") # causes NoMethodError | |||
| # | |||
| def public_send: (interned name, *untyped args) ?{ (*untyped) -> untyped } -> untyped | |||
| def public_send: (interned name, *untyped args, **untyped kwargs) ?{ (*untyped, **untyped) -> untyped } -> untyped | |||
ParadoxV5
reviewed
Nov 23, 2023
| @@ -2965,17 +2939,34 @@ module Kernel : BasicObject | |||
| # then {|url| URI(url).read }. | |||
| # then {|response| JSON.parse(response) } | |||
| # | |||
| def yield_self: [X] () { (self) -> X } -> X | |||
| def yield_self: [T] () { (self) -> T } -> T | |||
There was a problem hiding this comment.
Would conventions use R for Return?
Suggested change
| def yield_self: [T] () { (self) -> T } -> T | |
| def yield_self: [R] () { (self) -> R } -> R |
Co-authored-by: ParadoxV5 <[email protected]>
Co-authored-by: ParadoxV5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.