Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlib: Add type for CSV::Row#initialize #1903

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

aki19035vc
Copy link
Contributor

@aki19035vc aki19035vc commented Jun 21, 2024

Add type to CSV::Row#initialize in stdlib because the type does not exist.

The content of the headers array is untyped, because any object can be specified as long as it is an Ruby object.

I placed the test files directly under the stdlib directory, but please let me know if you need to create more directories like stdlib/csv!

Added CSV::Row#initialize in stdlib because the type does not exist.

The content of the headers array is `untyped`, because any object canbe specified as long as it is an Ruby object.

I placed the test files directly under the `stdlib` directory, but please let me know if you need to create more directories like `stdlib/csv`!
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.6 milestone Aug 5, 2024
@soutaro soutaro added this pull request to the merge queue Aug 5, 2024
Merged via the queue into ruby:master with commit f272675 Aug 5, 2024
19 checks passed
@soutaro soutaro added the Released PRs already included in the released version label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

2 participants