Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should validate self-type on Proc #2192

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Dec 20, 2024

Proc's self_type is not a validate target.

class Foo
  # validate pass
  def foo: () -> ^() [self: nothing] -> void
end

I fixed by including self_type in the checks for Types::Proc#{each_type,with_nonreturn_void?}.

@ParadoxV5
Copy link
Contributor

I’ve wondered how much code does RBS reuse on methods, blocks and procs.

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@soutaro soutaro added this pull request to the merge queue Dec 23, 2024
@soutaro soutaro added this to the RBS 3.8 milestone Dec 23, 2024
Merged via the queue into ruby:master with commit 393e2dd Dec 23, 2024
19 checks passed
@ksss ksss deleted the validate-proc-self-type branch December 23, 2024 02:48
@soutaro soutaro added the Released PRs already included in the released version label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

3 participants