Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember parentNode in case onChange callback mutates DOM #227

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Remember parentNode in case onChange callback mutates DOM #227

merged 1 commit into from
Nov 9, 2023

Commits on Nov 4, 2023

  1. Remember parentNode in case onChange callback mutates DOM 

    There's no guarantee that the onChange callback won't mutate the DOM in some way that removes the selected option node, thus creating a runtime error when null.dispatchEvent is called when trying to trigger the "blur" event on the parent. By saving the parentNode in a variable, we avoid this edge-case scenario.
    @botandrose @botandrose-machine
    botandrose authored and botandrose-machine committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    be57133 View commit details
    Browse the repository at this point in the history