Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay to dragging #257

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add delay to dragging #257

merged 1 commit into from
Mar 25, 2024

Conversation

trobrock
Copy link
Contributor

@trobrock trobrock commented Feb 9, 2024

I'm using SortableJS, which supports the ability to require the mouse be held for a period of time (in our case 300ms) before the user can drag the element.

Inspired by @swanson's work on #182 this adds the ability to add a delay between the mouse press and the drag.

This patch got our code off our custom drag_to method and onto this libraries. Usage is like this:

find(from).drag_to(find(to), steps: 10, delay: 0.3)

@trobrock
Copy link
Contributor Author

Is there anything I can do to move this forward?

@route
Copy link
Member

route commented Mar 24, 2024

@trobrock sorry it slipped through the cracks of my radar, could you please rebase on master? I'd like to run tests again?

@trobrock
Copy link
Contributor Author

@route no worries. Just rebased.

@route route merged commit 9e2788f into rubycdp:main Mar 25, 2024
5 checks passed
@route
Copy link
Member

route commented Mar 25, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants