-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate a FocusEvent (not Event) for focus-related events #272
base: main
Are you sure you want to change the base?
Conversation
ContextThe reason that this initially came to my attention (and my motivation for this change) is that a JavaScript library that I use ( Because currently on This change makes it so that those warnings are no longer printed when I use the Capybara |
Looking at the Ruby 3.3 test run, there are five failing specs (link). I believe that none of those failures are related to my change, and that those failures are already present on Edit: I submitted a separate PR to fix these spec failures. |
@@ -28,10 +28,10 @@ $(function() { | |||
$("#changes_on_keypress").text(increment) | |||
}) | |||
.focus(function(event) { | |||
$("#changes_on_focus").text("Focus") | |||
$("#changes_on_focus").text(`Focus (${event.originalEvent.constructor.name})`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like tests to cover the change in this PR, so I added the event constructor name in parentheses here. On main
, this text would be Focus (Event)
. On this branch, it's Focus (FocusEvent)
.
I have submitted a separate PR to fix these spec failures that currently exist on the |
Currently on
main
, focus-related events (blur, focus, focusin, and focusout) create a JavaScriptEvent
object.However, as can be seen by clicking into and out of the input in this JSFiddle (tested in Firefox 130 and Chrome 128), those events should actually be JavaScript
FocusEvent
objects (notEvent
objects).This change makes it so that Cuprite will generate
FocusEvent
objects (notEvent
objects) for focus-related events.