-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PHP-CS-Fixer to the latest version and enable parallelization #2222
Conversation
2d574bf
to
0d0cbd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall change LGTM, have left one question around the \
removal which shows up in several places and also needed test adjustments which makes me a bit nervous.
Is my understanding correct you want to get this in and follow on the phpunit change in a separate PR (my preference)
src/Util.php
Outdated
@@ -67,7 +67,7 @@ public static function escapeDateMath($requestUri) | |||
|
|||
// '\\{' and '\\}' should not be escaped | |||
if (\str_contains($uriSegment, '\\\\')) { | |||
$escapedUriSegment = \str_replace(['\\\\%7B', '\\\\%7D'], ['\\\\{', '\\\\}'], $escapedUriSegment); | |||
$escapedUriSegment = \str_replace(['\\\%7B', '\\\%7D'], ['\\\{', '\\\}'], $escapedUriSegment); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help me understand this change and the one below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably I could explain better than described in the https://mlocati.github.io/php-cs-fixer-configurator/#version:3.59|fixer:string_implicit_backslashes.
I decided to disable this rule so code stay as it was before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
0d0cbd0
to
7b34f0b
Compare
yes. This is my plan. Merge this PR and I could continue to work with phpunit migration |
…in order to speedup builds
7b34f0b
to
1f9226a
Compare
This PR updates PHP-CS-Fixer and enable parallelization.
Rules list which were applied:
All rules are default one now and are part of
@PhpCsFixer
, exceptfully_qualified_strict_types
.I enabled it in a purpose. I'm planning to upgrade PHPUnit to 10.5 and migrate from doc blocks to attributes with the help of
rectorphp
.So this rule will help me to fix code like:
to be
Benefits of enabling parallelization: