Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text-Viewer JS #4

Open
austgate opened this issue Dec 22, 2013 · 5 comments
Open

Text-Viewer JS #4

austgate opened this issue Dec 22, 2013 · 5 comments

Comments

@austgate
Copy link
Contributor

Do we want this to be configurable, or assume (as current), that is in one constant place?

@rufuspollock
Copy link

let's assume this is shipped as part of the wordpress plugin and so in one place ...

@austgate
Copy link
Contributor Author

austgate commented Jan 9, 2014

@rgrp I've updated Textus to include the JS from Textus Viewer.

@rufuspollock
Copy link

@austgate I've made major progress with https://github.com/okfn/textus-viewer and it is now pretty much usable (still some bugs to fix). Instructions on how to use at:

https://github.com/okfn/textus-viewer#usage

Note I recommend loading from okfnlabs.org/textus-viewer rather than including code into the app as I will be making further improvements - thus for vendor links you'll want:

http://okfnlabs.org/textus-viewer/vendor/jquery.ui-1.8.22.js
etc

Note don't worry if your jquery version is different.

@austgate
Copy link
Contributor Author

@rgrp the Wordpress code references the okfnlabs site at the moment. The text is being rendered, as are the notes (a little more work perhaps needs doing in this area on my side - such as adding new notes). Is there any other HTML that needs including? Currently just have the jQuery code on the main site but none of the options are being shown that are on the okfnlabs Textus site.

@austgate
Copy link
Contributor Author

@rgrp Perhaps nothing but I'm seeing:
Semantics changed - re-rendering viewer.js:233
event.returnValue is deprecated. Please use the standard event.preventDefault() instead. jquery-1.7.2.js:3526
in the console.
Assume that I can ignore this at the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants