Merge pull request #3 from doenietzomoeilijk/gpu-passthrough-intel-only

Use a slightly uglier but more reliable way of determining GRUB_CMDLINE_LINUX_DEFAULT

roles/grubcmdline/tasks/main.yml

@@ -15,16 +15,24 @@
   changed_when: old_cmdline != kernel_cmdline | select() | sort | list
   notify: "{{ kernel_restart_handler }}"
 
-- name: Slurp /etc/default/grub
-  ansible.builtin.slurp:
-    path: /etc/default/grub
-  register: grub_result
-  become: true
+- name: Look for the last occurance of GRUB_CMDLINE_LINUX_DEFAULT in grub config
+  # In some environments, the grub config contained multiple lines defining this
+  # value; the last one would "win", but the change in this play would be based
+  # on the first one that was found, with interesting consequences. Hence this
+  # slightly less pure but more reliable way of fetching that line.
+  ansible.builtin.shell:
+    cmd: >-
+      set -o pipefail
+      && grep -E '^GRUB_CMDLINE_LINUX_DEFAULT' /etc/default/grub | tail -1
+    args:
+      executable: /usr/bin/bash
+  register: grub_cmdline_linux_default
+  changed_when: grub_cmdline_linux_default.rc != 0
 
-- name: Set fact containing GRUB_CMDLINE_LINUX_DEFAULT
+- name: Set fact containing the contents of GRUB_CMDLINE_LINUX_DEFAULT
   ansible.builtin.set_fact:
     grub_cmdline_linux_default: >-
-      {{ grub_result.content | b64decode | regex_search('^GRUB_CMDLINE_LINUX_DEFAULT.*$', multiline=True) | regex_replace('^GRUB_CMDLINE_LINUX_DEFAULT="(.*)"$', '\1') }}
+      {{ grub_cmdline_linux_default.stdout | regex_search('^GRUB_CMDLINE_LINUX_DEFAULT.*$', multiline=True) | regex_replace('^GRUB_CMDLINE_LINUX_DEFAULT="(.*)"$', '\1') }}
 - name: Display GRUB_CMDLINE_DEFAULT
   ansible.builtin.debug:
     var: grub_cmdline_linux_default
@@ -33,7 +41,7 @@
   # We use a regex here so you can remove parameters regardless of their value, e.g to remove iommu=on you
   # could use the regex: ^iommu=
   ansible.builtin.set_fact:
-    grub_cmdline_linux_remove: "{{ grub_cmdline_linux_default.split() | select('search', kernel_cmdline_remove_regex) | list }}"
+    wrub_cmdline_linux_remove: "{{ grub_cmdline_linux_default.split() | select('search', kernel_cmdline_remove_regex) | list }}"
 
 - name: Display parameters to be removed
   ansible.builtin.debug: