Arcane Spellcasting Pt.2.5 (Spellbooks/Craft/Learn)

code/__DEFINES/roguetown.dm

@@ -87,3 +87,8 @@ GLOBAL_LIST_EMPTY(job_respawn_delays)
 #define TRIUMPH_CAT_CHARACTER "CHARACTER"
 #define TRIUMPH_CAT_MISC "MISC!"
 #define TRIUMPH_CAT_ACTIVE_DATUMS "ACTIVE"
+
+/*
+	Learnable arcane spell books
+*/
+GLOBAL_LIST_INIT(learnables, list())

code/__HELPERS/global_lists.dm

@@ -89,6 +89,9 @@
 		if(patron.preference_accessible)
 			GLOB.preference_patrons[path] = patron
 
+	// Learnable Arcane Spells
+	GLOB.learnables = Get_Learnable_Spells()
+
 //creates every subtype of prototype (excluding prototype) and adds it to list L.
 //if no list/L is provided, one is created.
 /proc/init_subtypes(prototype, list/L)

code/__HELPERS/unsorted.dm

@@ -50,6 +50,15 @@
 	else if(x<0)
 		.+=360
 
+//Get the all the damn arcane spells
+/proc/Get_Learnable_Spells()
+	var/ret = list()
+	for(var/S in GLOB.spells)
+		var/obj/effect/proc_holder/spell/arcane/spell = S
+		if(spell.learnable)
+			ret += spell
+	return ret
+
 //Returns location. Returns null if no location was found.
 /proc/get_teleport_loc(turf/location,mob/target,distance = 1, density = FALSE, errorx = 0, errory = 0, eoffsetx = 0, eoffsety = 0)
 /*

code/datums/status_effects/rogue/roguebuff.dm

@@ -146,3 +146,25 @@
 	name = "Dazed"
 	desc = ""
 	icon_state = "weed"
+
+/atom/movable/screen/alert/status_effect/buff/feather
+	name = "Featherweight"
+	desc = "My body is light, I can jump higher and falling from heights is not painful."
+	icon_state = "buff"
+
+/datum/status_effect/buff/feather
+	id = "feather"
+	alert_type = /atom/movable/screen/alert/status_effect/buff/feather
+	duration = 1 MINUTES
+
+/datum/status_effect/buff/feather/on_apply()
+	. = ..()
+	to_chat(owner, span_warning("I feel lighter."))
+	ADD_TRAIT(owner, TRAIT_NOFALLDAMAGE1, MAGIC_TRAIT)
+	ADD_TRAIT(owner, TRAIT_ZJUMP, MAGIC_TRAIT)
+
+/datum/status_effect/buff/feather/on_remove()
+	. = ..()
+	to_chat(owner, span_warning("The feeling of lightness fades."))
+	REMOVE_TRAIT(owner, TRAIT_NOFALLDAMAGE1, MAGIC_TRAIT)
+	REMOVE_TRAIT(owner, TRAIT_ZJUMP, MAGIC_TRAIT)

code/game/objects/effects/landmarks.dm

@@ -362,7 +362,7 @@ INITIALIZE_IMMEDIATE(/obj/effect/landmark)
 	icon_state = "arrow"
 
 /obj/effect/landmark/start/wapprentice
-	name = "Magician's Apprentice"
+	name = "Magician Apprentice"
 	icon_state = "arrow"
 
 /obj/effect/landmark/start/servant

code/game/objects/items/granters.dm

@@ -9,6 +9,7 @@
 	var/reading = FALSE //sanity
 	var/oneuse = TRUE //default this is true, but admins can var this to 0 if we wanna all have a pass around of the rod form book
 	var/used = FALSE //only really matters if oneuse but it might be nice to know if someone's used it for admin investigations perhaps
+	var/open = FALSE
 
 /obj/item/book/granter/proc/turn_page(mob/user)
 	playsound(user, pick('sound/blank.ogg'), 30, TRUE)
@@ -124,6 +125,7 @@
 	var/spell
 	var/spellname = "conjure bugs"
 
+/*
 /obj/item/book/granter/spell/already_known(mob/user)
 	if(!spell)
 		return TRUE
@@ -154,6 +156,7 @@
 	..()
 	if(oneuse)
 		user.visible_message(span_warning("[src] glows dark for a second!"))
+*/
 
 /obj/item/book/granter/spell/fireball
 	spell = /obj/effect/proc_holder/spell/aimed/fireball
@@ -508,3 +511,111 @@
 	spellname = "Bone Chill"
 	icon_state ="scrolldarkred"
 	remarks = list("Mediolanum ventis..", "Sana damnatorum..", "Frigidus ossa mortuorum..")
+
+//! --SPELL BOOKS-- !/
+
+/obj/item/book/granter/spell/generic
+	name = "Spellbook"
+	desc = "A book of potential known only to those that can decipher its secrets."
+	icon = 'icons/roguetown/items/books.dmi'
+	icon_state = "spell_book_0"
+	var/base_icon_state = "spell_book"
+	oneuse = TRUE
+	dropshrink = 0.6
+	drop_sound = 'sound/foley/dropsound/paper_drop.ogg'
+	pickup_sound =  'sound/blank.ogg'
+	force = 6
+	bookfile = "spellbook.json"
+	var/obj/effect/proc_holder/spell/arcane/target = null
+
+/obj/item/book/granter/spell/generic/Initialize(loc)
+	. = ..()
+	target = pick(GLOB.learnables)
+	var/obj/effect/proc_holder/spell/arcane/S = new target
+	spellname = S.name
+	name = "Tome of [spellname]"
+//----------------------------------------------
+
+/obj/item/book/granter/spell/generic/attack_self(mob/user)
+	if(!open)
+		attack_right(user)
+		return
+	..()
+	user.update_inv_hands()
+
+/obj/item/book/rogue/rmb_self(mob/user)
+	attack_right(user)
+	return
+
+/obj/item/book/rogue/read(mob/user)
+	if(!open)
+		to_chat(user, span_info("Open me first."))
+		return FALSE
+	. = ..()
+
+/obj/item/book/granter/spell/generic/attackby(obj/item/I, mob/user, params)
+	return
+
+/obj/item/book/granter/spell/generic/attack_right(mob/user)
+	if(!open)
+		slot_flags &= ~ITEM_SLOT_HIP
+		open = TRUE
+		playsound(loc, 'sound/items/book_open.ogg', 100, FALSE, -1)
+/*		if(user.mind.get_skill_level(/datum/skill/magic/arcane) >= 1 && user.mind.get_skill_level(/datum/skill/misc/reading) >= 3)//
+			to_chat(user, "<span class='notice'>You can grasp the arcane knowledge within this tome...</span>")//
+			playsound(loc, 'sound/magic/churn.ogg', 100, FALSE, -1)//
+		if(user.ranged_ability == !null)//
+			user.ranged_ability.deactivate(user.ranged_ability)//
+		user.ranged_ability = target//
+		user.ranged_ability.active = TRUE//
+		user.mmb_intent_change(QINTENT_SPELL)//
+Was trying to make so you can cast the spell holding the open book but I failed miserably...*/
+	else
+		slot_flags |= ITEM_SLOT_HIP
+		open = FALSE
+		playsound(loc, 'sound/items/book_close.ogg', 100, FALSE, -1)
+//		if (user.ranged_ability == target)//
+//			user.mmb_intent_change(null)//
+	curpage = 1
+	update_icon()
+	user.update_inv_hands()
+
+/obj/item/book/granter/spell/generic/update_icon()
+	icon_state = "[base_icon_state]_[open]"
+
+//----------------------------------------------
+/obj/item/book/granter/spell/generic/already_known(mob/user)
+	if(!target)
+		return TRUE
+	for(var/obj/effect/proc_holder/spell/arcane/knownspell in user.mind.spell_list)
+		if(knownspell.type == target)
+			to_chat(user,"<span class='warning'>You already know this one!</span>")
+			return TRUE
+	return FALSE
+
+/obj/item/book/granter/spell/generic/on_reading_start(mob/user)
+	to_chat(user, "<span class='notice'>I start reading about [spellname]...</span>")
+
+/obj/item/book/granter/spell/generic/on_reading_finished(mob/user)
+	. = ..()
+	var/learnedspells = 0
+	for(var/obj/effect/proc_holder/spell/arcane/knownspell in user.mind.spell_list)
+		learnedspells += 1
+	if(learnedspells == 0)
+		to_chat(user, "<span class='notice'>...You can't make sense of the sprawling runes...</span>")
+		return
+	else if(learnedspells >= (1 + user.mind.get_skill_level(/datum/skill/magic/arcane)))
+		to_chat(user, "<span class='notice'>You tried hard to grasp it, unfortunately you are at the limit of your current arcane power...</span>")
+		return
+	if(oneuse)
+		name = "Siphoned Tome"
+		desc = "A book once inscribed with magical scripture. The surface is now barren of knowledge, siphoned by someone else. It's utterly useless."
+		user.visible_message("<span class='warning'>[src] has had its magic ink ripped from the book!</span>")
+		icon_state = "used_spell_book_[open]"
+		base_icon_state = "used_spell_book"
+	to_chat(user, "<span class='notice'>Your knowledge expands, you understand how to cast [spellname]!</span>")
+	var/S = new target
+	user.mind.AddSpell(S)
+	//user.mind.adjust_experience(/datum/skill/misc/reading, user.STAINT) //cant find the user's STAINT here for some cursed reason...
+	user.log_message("learned the spell [target.name] ([target])", LOG_ATTACK, color="orange")
+	onlearned(user)

code/game/objects/items/rogueitems/books.dm

@@ -232,7 +232,7 @@
 	bookfile = "law.json"
 
 /obj/item/book/rogue/cooking
-	name = "Tastes Fit For The Lord" 
+	name = "Tastes Fit For The Lord"
 	desc = ""
 	icon_state ="book_0"
 	base_icon_state = "book"
@@ -392,14 +392,14 @@
 	icon_state = "basic_book_0"
 	base_icon_state = "basic_book"
 	override_find_book = TRUE
-	
+
 /obj/item/book/rogue/playerbook/Initialize(loc, in_round_player_generated, var/mob/living/in_round_player_mob, text)
 	. = ..()
 	is_in_round_player_generated = in_round_player_generated
 	if(is_in_round_player_generated)
 		player_book_text = text
 		while(!player_book_author_ckey) // doesn't have to be this, but better than defining a bool.
-			player_book_title = dd_limittext(capitalize(sanitize_hear_message(input(in_round_player_mob, "What title do you want to give the book? (max 42 characters)", "Title", "Unknown"))), MAX_NAME_LEN)	
+			player_book_title = dd_limittext(capitalize(sanitize_hear_message(input(in_round_player_mob, "What title do you want to give the book? (max 42 characters)", "Title", "Unknown"))), MAX_NAME_LEN)
 			player_book_author = "[dd_limittext(sanitize_hear_message(input(in_round_player_mob, "What do you want the author text to be? (max 42 characters)", "Author", "")), MAX_NAME_LEN)]"
 			player_book_icon = book_icons[input(in_round_player_mob, "Choose a book style", "Book Style") as anything in book_icons]
 			player_book_author_ckey = in_round_player_mob.ckey
@@ -437,6 +437,51 @@
 	var/qdel_source = FALSE
 
 /obj/item/manuscript/attackby(obj/item/I, mob/living/user)
+	if(resistance_flags & ON_FIRE)
+		return ..()
+
+	if(istype(I, /obj/item/natural/feather/magic))
+		if(src.number_of_pages <= 4)
+			to_chat(user, "This manuscript does not have enough pages to write an entire spellbook in it...")
+			return
+
+		var/obj/item/natural/feather/magic/F = I
+		var/arcane_score = 0
+		var/total_score = 0
+//		var/crafttime = 0  The crafting is currently instantaneous so no need for this shit (yet)
+
+//		 Make is so you can't write spellbooks if you are below Journeyman.
+		for(var/i in 1 to user.mind.get_skill_level(/datum/skill/magic/arcane))
+			arcane_score += 1
+		if(arcane_score <= 2)
+			to_chat(user, "You do not have enough arcane knowledge to inscribe a spellbook...")
+			return
+
+//		 The math here is so it is borderline impossible to get a 100% success chance, those are supposed to be hard to make
+		total_score += (arcane_score * 6) + (user.STAINT * 2)
+//		crafttime = 10 - arcane_score
+//		for(var/i in 1 to user.mind.get_skill_level(/datum/skill/misc/reading))
+//			total_score += 4
+		if(prob(total_score))
+			var/obj/item/book/granter/spell/generic/SB = new /obj/item/book/granter/spell/generic(get_turf(I.loc), pick(GLOB.learnables))
+			if(user.Adjacent(SB))
+				SB.add_fingerprint(user)
+				user.put_in_hands(SB)
+			user.mind.adjust_experience(/datum/skill/magic/arcane, user.STAINT*3)
+			to_chat(user, "As you finish writing, the feather glows and envelops the manuscript, becoming a new spellbook.")
+			qdel(src)
+		else
+			to_chat(user, "As you write, the feather glows but the magic gets out of control and the manuscript can not contain it, imploding it into dust.")
+			var/obj/O = new /obj/item/ash(get_turf(src.loc))
+			qdel(src)
+			explosion(O.loc,0,0,0,1,FALSE,,1,,TRUE)
+		// else something here about the feather not being able to write a spellbook
+		if(F.uses >= F.max_uses)
+			to_chat(user, "The feather's magic glows dimly, and then it turns into dust.")
+			new /obj/item/ash(get_turf(user.loc))
+			qdel(F)
+		return
+
 	// why is a book crafting kit using the craft system, but crafting a book isn't? Well the crafting system for *some reason* is made in such a way as to make reworking it to allow you to put reqs vars in the crafted item near *impossible.*
 	if(istype(I, /obj/item/book_crafting_kit))
 		qdel(I)

code/game/objects/items/rogueitems/keyrings.dm

@@ -158,6 +158,9 @@
 /obj/item/keyring/mage
 	keys = list(/obj/item/roguekey/manor, /obj/item/roguekey/tower, /obj/item/roguekey/mage)
 
+/obj/item/keyring/mageapprentice
+	keys = list(/obj/item/roguekey/tower, /obj/item/roguekey/mage)
+
 /obj/item/keyring/innkeep
 	keys = list(/obj/item/roguekey/tavern, /obj/item/roguekey/roomiv, /obj/item/roguekey/roomiii, /obj/item/roguekey/roomii, /obj/item/roguekey/roomi)
 

code/game/objects/items/rogueitems/natural/feather.dm

@@ -15,4 +15,11 @@
 	max_integrity = 20
 	muteinmouth = TRUE
 	spitoutmouth = FALSE
-	w_class = WEIGHT_CLASS_TINY
+	w_class = WEIGHT_CLASS_TINY
+
+/obj/item/natural/feather/magic
+	name = "magic feather"
+	color = "#ffee00"
+	desc = "A fluffy feather enveloped with magical aura."
+	var/uses = 0
+	var/max_uses = 3 // Maybe balance this more?

code/modules/jobs/job_types/roguetown/adventurer/types/combat/mage.dm

@@ -32,7 +32,6 @@
 	if(H.mind)
 		to_chat(H, span_warning("Magic is often times refered to as an art. At times it is treated as a primordial beast, chaos incarnate. To more learned men it is a precise science, to be studied and examined. In the end, magic is all three of the above. It is Art, Chaos, and Science: a blessing, a curse, and progress. It all depends on who calls upon it, and for what purpose."))
 		H.mind.adjust_skillrank(/datum/skill/combat/polearms, 1, TRUE)
-		H.mind.adjust_skillrank(/datum/skill/combat/bows, 1, TRUE)
 		H.mind.adjust_skillrank(/datum/skill/combat/wrestling, pick(0,1,2), TRUE)
 		H.mind.adjust_skillrank(/datum/skill/combat/unarmed, pick(0,1,2), TRUE)
 		H.mind.adjust_skillrank(/datum/skill/misc/swimming, 1, TRUE)
@@ -64,7 +63,15 @@
 			"/obj/effect/proc_holder/spell/arcane/smokescreen",
 			"/obj/effect/proc_holder/spell/arcane/blindness",
 			"/obj/effect/proc_holder/spell/arcane/invisibility",
-			"/obj/effect/proc_holder/spell/arcane/projectile/fetch"
+			"/obj/effect/proc_holder/spell/arcane/projectile/fetch",
+			"/obj/effect/proc_holder/spell/arcane/mist",
+			"/obj/effect/proc_holder/spell/arcane/web",
+			"/obj/effect/proc_holder/spell/arcane/feather",
+			"/obj/effect/proc_holder/spell/arcane/magicwall",
+			"/obj/effect/proc_holder/spell/arcane/ensnare",
+			"/obj/effect/proc_holder/spell/arcane/repulse",
+			"/obj/effect/proc_holder/spell/arcane/unlock",
+			"/obj/effect/proc_holder/spell/arcane/light"
 		)
 		H.mind.AddSpell(pick(new /obj/effect/proc_holder/spell/arcane/projectile/fireball,new /obj/effect/proc_holder/spell/arcane/projectile/lightningbolt))
 		for(var/i=2,i>0,i--)

code/modules/jobs/job_types/roguetown/adventurer/types/combat/sorceress.dm

@@ -31,19 +31,23 @@
 	r_hand = /obj/item/rogueweapon/woodstaff
 	if(H.mind)
 		H.mind.adjust_skillrank(/datum/skill/combat/polearms, 1, TRUE)
-		H.mind.adjust_skillrank(/datum/skill/combat/wrestling, pick(0,1,1), TRUE)
-		H.mind.adjust_skillrank(/datum/skill/combat/unarmed, pick(0,1,1), TRUE)
+		H.mind.adjust_skillrank(/datum/skill/combat/wrestling, pick(0,1,2), TRUE)
+		H.mind.adjust_skillrank(/datum/skill/combat/unarmed, pick(0,1,2), TRUE)
 		H.mind.adjust_skillrank(/datum/skill/misc/swimming, 1, TRUE)
 		H.mind.adjust_skillrank(/datum/skill/misc/climbing, pick(0,1), TRUE)
 		H.mind.adjust_skillrank(/datum/skill/misc/athletics, 1, TRUE)
-		H.mind.adjust_skillrank(/datum/skill/combat/knives, pick(0,1,1,2), TRUE)
+		H.mind.adjust_skillrank(/datum/skill/combat/swords, pick(0,1), TRUE)
+		H.mind.adjust_skillrank(/datum/skill/combat/knives, pick(0,1,2), TRUE)
 		H.mind.adjust_skillrank(/datum/skill/craft/crafting, pick(0,1), TRUE)
-		H.mind.adjust_skillrank(/datum/skill/misc/reading, 4, TRUE)
-		H.mind.adjust_skillrank(/datum/skill/misc/alchemy, 3, TRUE)
-		H.mind.adjust_skillrank(/datum/skill/magic/arcane, 2, TRUE)
-		H.mind.adjust_skillrank(/datum/skill/misc/medicine, 1, TRUE)
+		H.mind.adjust_skillrank(/datum/skill/misc/medicine, pick(0,1), TRUE)
+		H.mind.adjust_skillrank(/datum/skill/misc/riding, 1, TRUE)
+		H.mind.adjust_skillrank(/datum/skill/misc/reading, pick(2,3), TRUE)
+		H.mind.adjust_skillrank(/datum/skill/misc/alchemy, 2, TRUE)
+		H.mind.adjust_skillrank(/datum/skill/magic/arcane, 4, TRUE)
 		if(H.age == AGE_OLD)
-			H.mind.adjust_skillrank(/datum/skill/magic/arcane, pick(2,3,3), TRUE)
+			H.mind.adjust_skillrank(/datum/skill/magic/arcane, pick(3,4,4), TRUE)
+			H.change_stat("intelligence", 5)
+			H.change_stat("strength", -2)
 		H.change_stat("strength", -1)
 		H.change_stat("intelligence", 4)
 		H.change_stat("speed", 1)
@@ -55,7 +59,15 @@
 			"/obj/effect/proc_holder/spell/arcane/smokescreen",
 			"/obj/effect/proc_holder/spell/arcane/blindness",
 			"/obj/effect/proc_holder/spell/arcane/invisibility",
-			"/obj/effect/proc_holder/spell/arcane/projectile/fetch"
+			"/obj/effect/proc_holder/spell/arcane/projectile/fetch",
+			"/obj/effect/proc_holder/spell/arcane/mist",
+			"/obj/effect/proc_holder/spell/arcane/web",
+			"/obj/effect/proc_holder/spell/arcane/feather",
+			"/obj/effect/proc_holder/spell/arcane/magicwall",
+			"/obj/effect/proc_holder/spell/arcane/ensnare",
+			"/obj/effect/proc_holder/spell/arcane/repulse",
+			"/obj/effect/proc_holder/spell/arcane/unlock",
+			"/obj/effect/proc_holder/spell/arcane/light"
 		)
 		H.mind.AddSpell(pick(new /obj/effect/proc_holder/spell/arcane/projectile/fireball,new /obj/effect/proc_holder/spell/arcane/projectile/lightningbolt))
 		for(var/i=2,i>0,i--)