Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test fix for #109, run in full in CI #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dead-claudia
Copy link
Contributor

The other tests only needed modified to fix a column number. The action was mysteriously only running one of the tests - I've fixed that.

This should help prevent regressions for #109 and possibly others. I've verified they also failed prior to that patch.

@dead-claudia dead-claudia force-pushed the patch-2 branch 2 times, most recently from 3469629 to 5634427 Compare June 13, 2023 15:35
@dead-claudia
Copy link
Contributor Author

Don't merge this unless tests pass.

@dead-claudia dead-claudia changed the title chore: update tests to check for #109, run in full in ci chore: Test fix for #109, run in full in CI Jun 13, 2023
The other tests only needed modified to fix a column number. The
action was mysteriously only running one of the tests - I've fixed
that.

This should help prevent regressions for rust-cli#109 and possibly others.
I've verified they also failed prior to that patch.
@dead-claudia
Copy link
Contributor Author

dead-claudia commented Jun 13, 2023

I am not at all sure what's going on with Ubuntu. That step is passing for me in Debian 11 WSL:

$ cargo test --all
    Finished test [unoptimized + debuginfo] target(s) in 0.03s
     Running unittests src/main.rs (target/debug/deps/custom_panic_test-878234e7f7cc63d3)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/integration.rs (target/debug/deps/integration-68bf49e3a4f9858e)

running 2 tests
test release ... ignored
test debug ... ok

test result: ok. 1 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/debug/deps/human_panic-da53dffe375e1a86)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/main.rs (target/debug/deps/name_collision_test-f7afd69bf803d44c)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/integration.rs (target/debug/deps/integration-7ea103528d2884f8)

running 2 tests
test release ... ignored
test debug ... ok

test result: ok. 1 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/main.rs (target/debug/deps/single_panic_test-cc5dc4b4081ab14a)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/integration.rs (target/debug/deps/integration-d4e5e21018f78c23)

running 2 tests
test release ... ignored
test debug ... ok

test result: ok. 1 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests human-panic

running 1 test
test src/lib.rs - setup_panic (line 94) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.75s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant