-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kotlin unsigned type conversion #747
Fix kotlin unsigned type conversion #747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but why is supports_unsigned necessary? Would love some comments explaining that situation, and then feel free to merge
Ah, yes, I'll add a comment about this, good point! But, for the generated traits, we don't have a JNA That being said, the actual right way to do this is to subclass the JNA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, land once you have the code commented
Ok sweet, thanks! |
The type conversion on the FFI boundary was broken in Kotlin for unsigned types -- regular methods and trait methods need to be treated differently. This PR fixes the issue.