Add ReadNorFlash::read_if_not_empty
#65
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
if-not-empty
branch
from
8768823 to
9913ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat experimental change, where I'm mainly looking for feedback at first. There are two cases I can imagine, where erased flash may not read back as
0xFF:In "normal" cases,
read_if_not_emptyjust issues a single read and checks the bytes, like in the default implementation. In the case of ESP32, the implementation would issue a decryption-bypassing read first to check for the empty value, then read the decrypted bytes again if not empty.The goal of this addition is to enable storage solutions to work with flash encryption without any additional marker traits or similar complications.