Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release embedded-hal{,-async,-nb} v1.0.0-rc.1, embedded-hal-bus v0.1.0-rc.1 #485

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Release embedded-hal{,-async,-nb} v1.0.0-rc.1, embedded-hal-bus v0.1.0-rc.1 #485

merged 1 commit into from
Aug 15, 2023

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Aug 15, 2023 •
edited
Loading

Fixes #482
Fixes #483

@Dirbaio Dirbaio requested a review from a team as a code owner August 15, 2023 17:29
@Dirbaio Dirbaio changed the title Release embedded-hal{,-async,-bus} v1.0.0-rc.1, embedded-hal-bus v0.1.0-rc.1 Release embedded-hal{,-async,-nb} v1.0.0-rc.1, embedded-hal-bus v0.1.0-rc.1 Aug 15, 2023
@Dirbaio Dirbaio mentioned this pull request Aug 15, 2023
Closed
eldruin
eldruin reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Just a couple of nitpicks. I do not care about the formatting of the defmt 0.3 support but let's keep it consistent

embedded-hal/CHANGELOG.md Show resolved Hide resolved
embedded-hal/CHANGELOG.md Outdated Show resolved Hide resolved
embedded-hal-bus/README.md Outdated Show resolved Hide resolved
embedded-hal-bus/CHANGELOG.md Outdated Show resolved Hide resolved
embedded-hal-async/README.md Outdated Show resolved Hide resolved
embedded-hal-async/CHANGELOG.md Outdated Show resolved Hide resolved
embedded-hal/README.md Outdated Show resolved Hide resolved
embedded-io-async/README.md Outdated Show resolved Hide resolved
embedded-io/README.md Outdated Show resolved Hide resolved
eldruin
eldruin approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eldruin eldruin added this pull request to the merge queue Aug 15, 2023
Merged via the queue into rust-embedded:master with commit b6a7678 Aug 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document defmt feature Update changelogs
2 participants
@Dirbaio @eldruin