Use feature() on nightly toolchains only.
#534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`feature()` is only allowed on Nightly, it's completely disallowed on stable and beta even for already-stabilized features. So, we autodetect whether the user is using nightly and conditionally use `feature()`. This allows the crates to Just Work on current 1.75 beta and will also Just Work when 1.75 stable is out. Keeping `feature()` is desirable to keep support for: - Espressif's xtensa rustc fork. (they build from the stable branch but enable use of `feature()`, so latest xtensa rustc still requires `feature()`) - Users of older nightlies Once xtensa rust 1.75 is out, we can remove this (upstream nightlies that require `feature()` will be quite old by then, so dropping support for them should be OK). I decided to not use already-made crates like `rustversion` to do this because they're quite big and do way more than what we need, so I felt badd adding another dep. The code is inspired from `rustversion`'s build.rs.
Dirbaio
force-pushed
the
feature-nightly-only
branch
from
c5250aa
to
c9fbac0
Compare
MabezDev
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature()is only allowed on Nightly, it's completely disallowed on stable and betaeven for already-stabilized features. So, we autodetect whether the user is using nightly
and conditionally use
feature(). This allows the crates to Just Work on current 1.75 betaand will also Just Work when 1.75 stable is out.
Keeping
feature()is desirable to keep support for:feature(), so latest xtensa rustc still requiresfeature())Once xtensa rust 1.75 is out, we can remove this (upstream nightlies that require
feature()will be quite old by then, so dropping support for them should be OK).I decided to not use already-made crates like
rustversionto do this because they're quite big and do way more than what we need, so I felt badd adding another dep. The code is inspired fromrustversion's build.rs.