Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract crates_io_database crate #9648

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 13, 2024

This crate only contains the database schema at the moment, but could be extended with other purely database-related code in the future. This should hopefully help with untangling our mess of interdependencies in the models module.

This might also help a little bit with compile times of the crates_io crate, since all of the table!() macros can be expanded once and can then be cached since the schema does not change that often.

Finally, it would make it possible for other subcrates to depend on the schema, without pulling in all of the other crates_io code.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Oct 13, 2024
@Turbo87 Turbo87 requested a review from a team October 13, 2024 10:03
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (5673bdd) to head (2c72b22).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9648   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files         287      287           
  Lines       29339    29339           
=======================================
  Hits        26028    26028           
  Misses       3311     3311           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 16, 2024

alright, looks like no objections, so let's do this :)

@Turbo87 Turbo87 merged commit d7c7c56 into rust-lang:main Oct 16, 2024
11 checks passed
@Turbo87 Turbo87 deleted the database-crate branch October 16, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant