Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardized variable names for InterpCx #4018

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Standardized variable names for InterpCx #4018

merged 1 commit into from
Nov 8, 2024
+36 −36

Conversation

YohDeadfall
Copy link
Contributor

@YohDeadfall YohDeadfall commented Nov 7, 2024 •
edited
Loading

Partly addresses #3958.

RalfJung
RalfJung approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look fine. :)

Why is this marked as "draft"?

@YohDeadfall
Copy link
Contributor Author

It doesn't touch ecx:/this: but the issue asks to address that too. So, as soon as there's a decision on argument names I will make another commit.

@RalfJung
Copy link
Member

RalfJung commented Nov 8, 2024

You can also just make another PR then. Smaller PRs are generally better. :)

@YohDeadfall YohDeadfall marked this pull request as ready for review November 8, 2024 14:56
@RalfJung RalfJung added this pull request to the merge queue Nov 8, 2024
Merged via the queue into rust-lang:master with commit b9aecc8 Nov 8, 2024
7 checks passed
@YohDeadfall YohDeadfall deleted the ecx-name-standardization branch November 8, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YohDeadfall @RalfJung