Create tooling for end-to-end testing #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create two different tools:
- `test-drive`: A rustc_driver that compiles a crate and run a few
sanity checks on StableMIR.
- `compiletest`: A wrapper to run compiler tests using the
`test-drive` tool.
I am also adding a script to run a few rustc tests and a nightly
workflow. The files diff is not quite working yet so most tests
that fail compilation don't succeed yet.
oli-obk
reviewed
Sep 1, 2023
oli-obk
reviewed
Sep 1, 2023
Closed
oli-obk
reviewed
Sep 1, 2023
celinval
force-pushed
the
test-driver
branch
from
039c655
to
bc4c998
Compare
celinval
force-pushed
the
test-driver
branch
from
bc4c998
to
825e1bc
Compare
|
@oli-obk this is ready for review |
oli-obk
reviewed
Sep 26, 2023
I had forgotten to enable the smir checks before. Unfortunately, enabling them triggered a few issues. For now, I set the rustc suite to not fail the CI and created issue rust-lang#39 to track the work needed to enable it.
oli-obk
approved these changes
Sep 27, 2023
|
hmm... do we need bors for merging now? @bors r+ |
|
Nope... 😆 uh what now. I can't merge PRs anymore |
|
Maybe after https://github.com/rust-lang/project-stable-mir/pull/19/files we need to do something to the edit: afaict we do have the right permissions... |
Oh no! 🤦♀️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create two different tools:
test-drive: A rustc_driver that compiles a crate and run a few sanity checks on StableMIR.compiletest: A wrapper to run compiler tests using thetest-drivetool.I am also adding a script to run a few rustc tests and a nightly workflow. The files diff is not quite working yet so most tests that fail compilation don't succeed yet.
For our local tests, so far I created two suites (one with a test each): sanity-checks and fixme suite. The fixme suite is for issues that we find that needs fixing. I found an issue on the Trait API. I haven't debugged it yet.