Add Spec Identifier Syntax to expressions.md and subchapters #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpr, tuple-expr, and underscore-expr
chorman0773
added
S-waiting-on-review
90 tasks
traviscross
reviewed
Aug 27, 2024
traviscross
requested changes
Oct 18, 2024
| @@ -169,29 +197,46 @@ Explicitly, the assignee expressions are: | |||
| fields). | |||
| - [Unit structs][_StructExpression_]. | |||
|
|
|||
| r[expr.place-value.parentehesis] | |||
There was a problem hiding this comment.
Suggested change
| r[expr.place-value.parentehesis] | |
| r[expr.place-value.parenthesis] |
| Unlike other expressions, parenthesized expressions are both [place expressions and value expressions][place]. | ||
| When the enclosed operand is a place expression, it is a place expression and when the enclosed operand is a value expression, it is a value expression. | ||
|
|
||
| r[expr.paren.overridew-precedence] |
There was a problem hiding this comment.
Suggested change
| r[expr.paren.overridew-precedence] | |
| r[expr.paren.override-precedence] |
| When looking up a method call, the receiver may be automatically dereferenced or borrowed in order to call a method. | ||
| This requires a more complex lookup process than for other functions, since there may be a number of possible methods to call. | ||
| The following procedure is used: | ||
|
|
||
| r[expr.method.candidate-recievers] |
There was a problem hiding this comment.
Suggested change
| r[expr.method.candidate-recievers] | |
| r[expr.method.candidate-receivers] |
| The first step is to build a list of candidate receiver types. | ||
| Obtain these by repeatedly [dereferencing][dereference] the receiver expression's type, adding each type encountered to the list, then finally attempting an [unsized coercion] at the end, and adding the result type if that is successful. | ||
|
|
||
| r[expr.method.candidate-recievers-refs] |
There was a problem hiding this comment.
Suggested change
| r[expr.method.candidate-recievers-refs] | |
| r[expr.method.candidate-receivers-refs] |
| @@ -58,11 +69,14 @@ Then, for each candidate type `T`, search for a [visible] method with a receiver | |||
| > } | |||
| > ``` | |||
|
|
|||
| r[expr.method.ambiguious-target] | |||
There was a problem hiding this comment.
Suggested change
| r[expr.method.ambiguious-target] | |
| r[expr.method.ambiguous-target] |
| This process does not take into account the mutability or lifetime of the receiver, or whether a method is `unsafe`. | ||
| Once a method is looked up, if it can't be called for one (or more) of those reasons, the result is a compiler error. | ||
|
|
||
| r[expr.method.ambiguious-search] |
There was a problem hiding this comment.
Suggested change
| r[expr.method.ambiguious-search] | |
| r[expr.method.ambiguous-search] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds identifier syntax to
expressions.mdand all subchapters.