Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Default field values #3681

Merged
merged 37 commits into from
Nov 3, 2024
Merged

[RFC] Default field values #3681

merged 37 commits into from
Nov 3, 2024
+1,977 −0

Commits on Aug 22, 2024

  1. default-field-values: initial version

    @estebank
    estebank committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d81136d View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Remove example of using the functional update syntax and reword summary

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7d3823b View commit details
    Browse the repository at this point in the history

  2. Change argument for non_exhaustive to not allow it at first

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    608c47c View commit details
    Browse the repository at this point in the history

  3. mention future lint

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    14496f3 View commit details
    Browse the repository at this point in the history

  4. const patterns drawback

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    4564ea2 View commit details
    Browse the repository at this point in the history

  5. changes to privacy rules

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ba93bfc View commit details
    Browse the repository at this point in the history

  6. add suggested paragraph

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    607271b View commit details
    Browse the repository at this point in the history

  7. Add review comments, talk about _ in struct literals

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    89e466d View commit details
    Browse the repository at this point in the history

  8. mention drawback of complexity of choice

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    37bb518 View commit details
    Browse the repository at this point in the history

  9. remove PhantomData argument as it is no longer necessary

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9d528a3 View commit details
    Browse the repository at this point in the history

  10. link to RFC-0736

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    cb47c9b View commit details
    Browse the repository at this point in the history

  11. remove dynamic semantics section

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9862441 View commit details
    Browse the repository at this point in the history

  12. incorporate review feedback

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ed92669 View commit details
    Browse the repository at this point in the history

  13. fix typo

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6aa312d View commit details
    Browse the repository at this point in the history

  14. use better structopt example

    @estebank
    estebank committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    76e9a4c View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. some tmandry comments

    @estebank
    estebank committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    b34f44c View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. mention enum variant derive default issue

    @estebank
    estebank committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    351f897 View commit details
    Browse the repository at this point in the history

  2. move privacy behavior changes to future possibilities

    @estebank
    estebank committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    94c8d48 View commit details
    Browse the repository at this point in the history

  3. add xlink

    @estebank
    estebank committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    f07e3a8 View commit details
    Browse the repository at this point in the history

  4. mention accessing assoc-consts is allowed

    @estebank
    estebank committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    ae62f32 View commit details
    Browse the repository at this point in the history

  5. Mention _ for tuples

    @estebank
    estebank committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    ff6e687 View commit details
    Browse the repository at this point in the history

  6. link to perfect derives explanation

    @estebank
    estebank committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    aaf9b9a View commit details
    Browse the repository at this point in the history

  7. expand typeck rules to describe mir expansion

    @estebank
    estebank committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    280c94f View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. mention the possibility to side-step imperfect derives

    @estebank
    estebank committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9a3d726 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Update 0000-default-field-values.md 

    Tweak `pub(default)` syntax
    @estebank
    estebank authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    013a03c View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Update 0000-default-field-values.md 

    mention that `Default` `impl`s are not `~const` today
    @estebank
    estebank authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    121a3c0 View commit details
    Browse the repository at this point in the history

  2. Mention possibility of linting bad const default values 

    Ment
    @estebank
    estebank authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    76b4016 View commit details
    Browse the repository at this point in the history

  3. Tweak wording of non_exhaustive subtleties

    @estebank
    estebank authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    2bf1c68 View commit details
    Browse the repository at this point in the history

  4. Fix links and typo

    @estebank
    estebank authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1f380fc View commit details
    Browse the repository at this point in the history

  5. Change FRU wording and links

    @estebank
    estebank authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    318f5e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Update outdated const context message

    @estebank
    estebank authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3148a9f View commit details
    Browse the repository at this point in the history

  2. Tweak wording 

    Co-authored-by: Ralf Jung <[email protected]>
    @estebank @RalfJung
    estebank and RalfJung authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    79e9f1b View commit details
    Browse the repository at this point in the history

  3. Remove caveat that is no longer true

    @estebank
    estebank authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b6a05d0 View commit details
    Browse the repository at this point in the history

  4. expand iif

    @estebank
    estebank authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e4101cc View commit details
    Browse the repository at this point in the history

  5. fix typo

    @estebank
    estebank authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3ed9f27 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Update text/0000-default-field-values.md 

    Co-authored-by: Felix S Klock II <[email protected]>
    @estebank @pnkfelix
    estebank and pnkfelix authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    096fa1c View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. Prepare RFC 3681 to be merged

    @traviscross
    traviscross committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    80e8d0b View commit details
    Browse the repository at this point in the history