Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declarative macro_rules! attribute macros #3697

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Declarative macro_rules! attribute macros #3697

wants to merge 27 commits into from
+222 −0

Commits on Sep 21, 2024

  1. Declarative macro_rules! attribute macros

    @joshtriplett
    joshtriplett committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    661912e View commit details
    Browse the repository at this point in the history

  2. RFC 3697

    @joshtriplett
    joshtriplett committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    6c9944b View commit details
    Browse the repository at this point in the history

  3. Attribute macros are active

    @joshtriplett
    joshtriplett committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    6fd82e8 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @joshtriplett
    joshtriplett committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    2b4989b View commit details
    Browse the repository at this point in the history

  5. Remove the extra =>

    @joshtriplett
    joshtriplett committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    258608e View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. Abbreviate to attr, with cfg_attr as precedent

    @joshtriplett
    joshtriplett committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    fa7820f View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Mention $crate

    @joshtriplett
    joshtriplett committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0e4e46c View commit details
    Browse the repository at this point in the history

  2. Caching

    @joshtriplett
    joshtriplett committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0fea475 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Add an alternative way of marking and handling attr/non-attr macros

    @joshtriplett
    joshtriplett committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b11f474 View commit details
    Browse the repository at this point in the history

  2. Clarify justification for having a single macro support attr and non-… 

    …attr
    @joshtriplett
    joshtriplett committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d13e2ba View commit details
    Browse the repository at this point in the history

  3. Add notes about backwards compatibility of adding attr rules

    @joshtriplett
    joshtriplett committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0900f9f View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Note that both MacroMatchers share the same namespace

    @joshtriplett
    joshtriplett committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    26e6969 View commit details
    Browse the repository at this point in the history

  2. Document the cases of no arguments and empty arguments

    @joshtriplett
    joshtriplett committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5cfb620 View commit details
    Browse the repository at this point in the history

  3. Future possibilities: better error reporting

    @joshtriplett
    joshtriplett committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    10f011d View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Add drawbacks section mentioning impact on crate maintainers

    @joshtriplett
    joshtriplett committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1cfec3d View commit details
    Browse the repository at this point in the history

  2. Expand future work

    @joshtriplett
    joshtriplett committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b7d4e06 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Future possibilities: consider the case of multiple attributes in any… 

    … order
    @joshtriplett
    joshtriplett committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0110363 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Recursion

    @joshtriplett
    joshtriplett committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    23cd82f View commit details
    Browse the repository at this point in the history

  2. Clarify recursive invocation 

    Co-authored-by: Mads Marquart <[email protected]>
    @joshtriplett @madsmtm
    joshtriplett and madsmtm authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9fbf852 View commit details
    Browse the repository at this point in the history

  3. Fix typo 

    Co-authored-by: Jacob Lifshay <[email protected]>
    @joshtriplett @programmerjake
    joshtriplett and programmerjake authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    95838c4 View commit details
    Browse the repository at this point in the history

  4. Add unresolved question to make sure we don't have awful error messages

    @joshtriplett
    joshtriplett committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    ff26c82 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Word-wrapping

    @joshtriplett
    joshtriplett committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    25ab000 View commit details
    Browse the repository at this point in the history

  2. Support unsafe attributes

    @joshtriplett
    joshtriplett committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    66ac59f View commit details
    Browse the repository at this point in the history

  3. Copy a drawback to the unresolved questions section

    @joshtriplett
    joshtriplett committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5fdd0d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Fix missing backquote

    @joshtriplett
    joshtriplett committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f2eb3ed View commit details
    Browse the repository at this point in the history

  2. Example

    @joshtriplett
    joshtriplett committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    27efc29 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Document that an attribute macro may invoke another, or itself

    @joshtriplett
    joshtriplett committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    e43905e View commit details
    Browse the repository at this point in the history