Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template encouraging inline comments over normal comments #3717

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Oct 24, 2024

  1. Add PR template encouraging inline comments over normal comments

    RFC threads are known for turning into huge messes once many comments arrive.
    One among many reasons for this is that the comments are entirely disorganized, which makes it very hard to keep track.
    
    I propose adding a warning the PR template that will strongly encourage people to leave inline review comments.
    These are significantly easier to keep track of (and can be resolved, hiding them!).
    Noratrieb authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ce06392 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f1d554e View commit details
    Browse the repository at this point in the history
  3. Update .github/PULL_REQUEST_TEMPLATE.md

    Co-authored-by: Eric Huss <[email protected]>
    Noratrieb and ehuss authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9504a83 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    44053e9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ecdb951 View commit details
    Browse the repository at this point in the history