Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Option::map_or(true, …) in unnecessary_map_or lint #13653

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Nov 4, 2024

If #11796 is not merged first, this PR will include its code as well as it builds on it. In this case, the changelog for the consolidated PR would be:

changelog: [unnecessary_map_or]: new lint

changelog: [unnecessary_map_or]: handle Option::map_or(true, …)

@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 4, 2024
@samueltardieu
Copy link
Contributor Author

Even though it is not to be merged yet (mostly because #11796 isn't merged),

r? @Centri3

@bors
Copy link
Contributor

bors commented Nov 7, 2024

☔ The latest upstream changes (presumably #13639) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants