Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for #112905 #127435

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Add tests for #112905 #127435

merged 1 commit into from
Jul 13, 2024

Conversation

GrigorenkoPV
Copy link
Contributor

This is a part of #105107. Adds the tests from the OP in #112905.

@rustbot
Copy link
Collaborator

rustbot commented Jul 6, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 6, 2024
@oskgo
Copy link
Contributor

oskgo commented Jul 7, 2024

Nit: file name should probably be dyn-erasure-no-tait.rs rather than dyn-erasure-no-tair.rs?

@GrigorenkoPV
Copy link
Contributor Author

Nit: file name should probably be dyn-erasure-no-tait.rs rather than dyn-erasure-no-tair.rs?

Absolutely

@cjgillot
Copy link
Contributor

fyi @lcnr
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 13, 2024

📌 Commit 32294aa has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2024
@bors
Copy link
Contributor

bors commented Jul 13, 2024

⌛ Testing commit 32294aa with merge 25acbbd...

@bors
Copy link
Contributor

bors commented Jul 13, 2024

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 25acbbd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 13, 2024
@bors bors merged commit 25acbbd into rust-lang:master Jul 13, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 13, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (25acbbd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 704.365s -> 706.847s (0.35%)
Artifact size: 328.69 MiB -> 328.68 MiB (-0.00%)

@GrigorenkoPV GrigorenkoPV deleted the tests-for-112905 branch July 13, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GrigorenkoPV @rustbot @oskgo @cjgillot @bors @rust-timer